[jira] Reopened: (FILEUPLOAD-137) MultipartStream public API broken

["Henri Yandell (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FILEUPLOAD-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell reopened FILEUPLOAD-137:
--------------------------------------


Still a problem. According to findbugs, there are still errors:

"Message:  Non-virtual method call in org.apache.commons.fileupload.MultipartStream.MultipartStream() passes null for unconditionally dereferenced parameter of org.apache.commons.fileupload.MultipartStream.MultipartStream(java.io.InputStream,byte[],MultipartStream)"

Looking at the code, the boundary parameter jumps out as one that will throw an NPE if you call new MultipartStream().

> MultipartStream public API broken
> ---------------------------------
>
>                 Key: FILEUPLOAD-137
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-137
>             Project: Commons FileUpload
>          Issue Type: Bug
>    Affects Versions: 1.2
>            Reporter: Mark Sinke
>            Assignee: Jochen Wiedmann
>             Fix For: 1.2.1
>
>
> In commons-transaction 1.2 the MultipartStream class has 2 public constructors. Both are deprecated; however their implementation delegates to non-visible (package-private) constructors. There are two issues here:
> 1. the deprecated, delegating constructors use a null pointer for the progress notifier, which in turn yield a NullPointerException when you try to use them
> 2. the non-deprecated constructors are not visible.
> Hence, I cannot really upgrade from 1.0 to 1.2.
> Thanks,
> Mark.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org