You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/05/06 10:00:31 UTC

[GitHub] [ignite-3] sanpwc commented on a change in pull request #114: IGNITE-14666 Add proper listener handling in DistributedConfigurationStorage and LocalConfigurationStorage

sanpwc commented on a change in pull request #114:
URL: https://github.com/apache/ignite-3/pull/114#discussion_r627280889



##########
File path: modules/configuration/src/main/java/org/apache/ignite/configuration/storage/ConfigurationStorage.java
##########
@@ -44,6 +44,8 @@
      * Add listener to the storage that notifies of data changes.
      * @param listener Listener.
      */
+    // TODO: seems that it's not needed to have an ability to set several listeners to storage, as far as only one is responsible

Review comment:
       Let's remove addListener() and use constructor instead of it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org