You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/11/29 04:58:09 UTC
[kudu-CR] WIP [build-and-test] run 'gradle clean' before building Java
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22144
Change subject: WIP [build-and-test] run 'gradle clean' before building Java
......................................................................
WIP [build-and-test] run 'gradle clean' before building Java
WIP:
* add proper description
* clarify on the reproduction scenario when gradle's copyDistTestJars
task didn't properly process updates on the versions of dependencies
Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
---
M build-support/jenkins/build-and-test.sh
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/22144/1
--
To view, visit http://gerrit.cloudera.org:8080/22144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22144
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [build-and-test] run 'gradle clean' before building Java
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22144 )
Change subject: [build-and-test] run 'gradle clean' before building Java
......................................................................
Patch Set 3:
> (1 comment)
Thank you for review.
Right -- those old build machines didn't have much memory, but now it's more. Also, it was Gradle 6.
Yes, I'll keep an eye on errors like that.
--
To view, visit http://gerrit.cloudera.org:8080/22144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22144
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Dec 2024 15:41:19 +0000
Gerrit-HasComments: No
[kudu-CR] [build-and-test] run 'gradle clean' before building Java
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22144 )
Change subject: [build-and-test] run 'gradle clean' before building Java
......................................................................
Patch Set 3: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/832/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22144
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Dec 2024 21:59:56 +0000
Gerrit-HasComments: No
[kudu-CR] [build-and-test] run 'gradle clean' before building Java
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22144 )
Change subject: [build-and-test] run 'gradle clean' before building Java
......................................................................
Patch Set 3: Verified+1
unrelated test failures in well-known flaky tests (RELEASE build only)
--
To view, visit http://gerrit.cloudera.org:8080/22144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22144
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Dec 2024 23:09:42 +0000
Gerrit-HasComments: No
[kudu-CR] [build-and-test] run 'gradle clean' before building Java
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22144
to look at the new patch set (#3).
Change subject: [build-and-test] run 'gradle clean' before building Java
......................................................................
[build-and-test] run 'gradle clean' before building Java
When updating Java dependencies in changelists [1] and [2], I noticed
that pre-commit builds were failing fail because the copyDistTestJars
task wouldn't copy all the necessary JARs to into the staging directory
for dist-test since gradle would assume the target is up-to-date.
I think that was due to the fact that the same workspace was re-used
between different builds, and no 'clean' task was run.
This changelist is to address the issue. To avoid incurring the penalty
of rebuilding Java bits from scratch, this patch enables gradle's build
cache. As per [3], this is exactly the use-case to benefit from gradle's
caching. In addition, this patch re-enables parallel builds as well.
[1] https://github.com/apache/kudu/commit/b009144cd
[2] https://github.com/apache/kudu/commit/150ec7ff5
[3] https://docs.gradle.org/current/userguide/part6_gradle_caching.html
Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
---
M build-support/jenkins/build-and-test.sh
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/22144/3
--
To view, visit http://gerrit.cloudera.org:8080/22144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22144
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] WIP [build-and-test] run 'gradle clean' before building Java
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22144 )
Change subject: WIP [build-and-test] run 'gradle clean' before building Java
......................................................................
Patch Set 2: Verified+1
Build Successful
http://jenkins.kudu.apache.org/job/pre_commit/733/ : SUCCESS
--
To view, visit http://gerrit.cloudera.org:8080/22144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22144
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 03 Dec 2024 01:26:46 +0000
Gerrit-HasComments: No
[kudu-CR] [build-and-test] run 'gradle clean' before building Java
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [build-and-test] run 'gradle clean' before building Java
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/22144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22144
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [build-and-test] run 'gradle clean' before building Java
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22144 )
Change subject: [build-and-test] run 'gradle clean' before building Java
......................................................................
[build-and-test] run 'gradle clean' before building Java
When updating Java dependencies in changelists [1] and [2], I noticed
that pre-commit builds were failing fail because the copyDistTestJars
task wouldn't copy all the necessary JARs to into the staging directory
for dist-test since gradle would assume the target is up-to-date.
I think that was due to the fact that the same workspace was re-used
between different builds, and no 'clean' task was run.
This changelist is to address the issue. To avoid incurring the penalty
of rebuilding Java bits from scratch, this patch enables gradle's build
cache. As per [3], this is exactly the use-case to benefit from gradle's
caching. In addition, this patch re-enables parallel builds as well.
[1] https://github.com/apache/kudu/commit/b009144cd
[2] https://github.com/apache/kudu/commit/150ec7ff5
[3] https://docs.gradle.org/current/userguide/part6_gradle_caching.html
Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Reviewed-on: http://gerrit.cloudera.org:8080/22144
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M build-support/jenkins/build-and-test.sh
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Alexey Serbin: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/22144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22144
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [build-and-test] run 'gradle clean' before building Java
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22144 )
Change subject: [build-and-test] run 'gradle clean' before building Java
......................................................................
Patch Set 3:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/832/
--
To view, visit http://gerrit.cloudera.org:8080/22144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22144
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Dec 2024 20:51:30 +0000
Gerrit-HasComments: No
[kudu-CR] WIP [build-and-test] run 'gradle clean' before building Java
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22144 )
Change subject: WIP [build-and-test] run 'gradle clean' before building Java
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/733/
--
To view, visit http://gerrit.cloudera.org:8080/22144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22144
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 02 Dec 2024 23:09:08 +0000
Gerrit-HasComments: No
[kudu-CR] WIP [build-and-test] run 'gradle clean' before building Java
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22144 )
Change subject: WIP [build-and-test] run 'gradle clean' before building Java
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/725/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22144
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 29 Nov 2024 06:35:08 +0000
Gerrit-HasComments: No
[kudu-CR] [build-and-test] run 'gradle clean' before building Java
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22144 )
Change subject: [build-and-test] run 'gradle clean' before building Java
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22144/3/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
http://gerrit.cloudera.org:8080/#/c/22144/3/build-support/jenkins/build-and-test.sh@a349
PS3, Line 349:
Guess it makes sense to keep an eye on the failures reported below and we have to revert back the no-parallel configuration unless something changed:
http://gerrit.cloudera.org:8080/15453
--
To view, visit http://gerrit.cloudera.org:8080/22144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22144
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Dec 2024 07:21:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] WIP [build-and-test] run 'gradle clean' before building Java
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22144 )
Change subject: WIP [build-and-test] run 'gradle clean' before building Java
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/725/
--
To view, visit http://gerrit.cloudera.org:8080/22144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22144
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 29 Nov 2024 04:58:11 +0000
Gerrit-HasComments: No