You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2021/08/31 14:29:55 UTC
[kudu-CR] [client] Fix KuduSchema operator != bug
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17822
Change subject: [client] Fix KuduSchema operator != bug
......................................................................
[client] Fix KuduSchema operator != bug
Operator != of KuduSchema should operate on objects not pointers.
Change-Id: I1c49feff42114e72c229a77ea502deca60bb3209
---
M src/kudu/client/client-unittest.cc
M src/kudu/client/schema.cc
2 files changed, 33 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/17822/1
--
To view, visit http://gerrit.cloudera.org:8080/17822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c49feff42114e72c229a77ea502deca60bb3209
Gerrit-Change-Number: 17822
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [client] Fix KuduSchema operator != bug
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17822 )
Change subject: [client] Fix KuduSchema operator != bug
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
http://gerrit.cloudera.org:8080/#/c/17822/2/src/kudu/client/client-unittest.cc
File src/kudu/client/client-unittest.cc:
http://gerrit.cloudera.org:8080/#/c/17822/2/src/kudu/client/client-unittest.cc@304
PS2, Line 304: ASSERT_TRUE
nit: could use ASSERT_EQ() here?
http://gerrit.cloudera.org:8080/#/c/17822/2/src/kudu/client/client-unittest.cc@325
PS2, Line 325: s1
typo: s3 ?
http://gerrit.cloudera.org:8080/#/c/17822/2/src/kudu/client/schema.cc
File src/kudu/client/schema.cc:
http://gerrit.cloudera.org:8080/#/c/17822/2/src/kudu/client/schema.cc@872
PS2, Line 872: return !(*this == rhs);
Nice catch!
--
To view, visit http://gerrit.cloudera.org:8080/17822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c49feff42114e72c229a77ea502deca60bb3209
Gerrit-Change-Number: 17822
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Tue, 31 Aug 2021 16:39:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] [client] Fix KuduSchema operator != bug
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17822
to look at the new patch set (#3).
Change subject: [client] Fix KuduSchema operator != bug
......................................................................
[client] Fix KuduSchema operator != bug
Operator != of KuduSchema should operate on objects not pointers.
Change-Id: I1c49feff42114e72c229a77ea502deca60bb3209
---
M src/kudu/client/client-unittest.cc
M src/kudu/client/schema.cc
2 files changed, 42 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/17822/3
--
To view, visit http://gerrit.cloudera.org:8080/17822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1c49feff42114e72c229a77ea502deca60bb3209
Gerrit-Change-Number: 17822
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [client] Fix KuduSchema operator != bug
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17822 )
Change subject: [client] Fix KuduSchema operator != bug
......................................................................
[client] Fix KuduSchema operator != bug
Operator != of KuduSchema should operate on objects not pointers.
Change-Id: I1c49feff42114e72c229a77ea502deca60bb3209
Reviewed-on: http://gerrit.cloudera.org:8080/17822
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/client/client-unittest.cc
M src/kudu/client/schema.cc
2 files changed, 42 insertions(+), 2 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c49feff42114e72c229a77ea502deca60bb3209
Gerrit-Change-Number: 17822
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [client] Fix KuduSchema operator != bug
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17822
to look at the new patch set (#2).
Change subject: [client] Fix KuduSchema operator != bug
......................................................................
[client] Fix KuduSchema operator != bug
Operator != of KuduSchema should operate on objects not pointers.
Change-Id: I1c49feff42114e72c229a77ea502deca60bb3209
---
M src/kudu/client/client-unittest.cc
M src/kudu/client/schema.cc
2 files changed, 42 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/17822/2
--
To view, visit http://gerrit.cloudera.org:8080/17822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1c49feff42114e72c229a77ea502deca60bb3209
Gerrit-Change-Number: 17822
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [client] Fix KuduSchema operator != bug
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17822 )
Change subject: [client] Fix KuduSchema operator != bug
......................................................................
Patch Set 3: Code-Review+2
Thank you for the fix!
--
To view, visit http://gerrit.cloudera.org:8080/17822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c49feff42114e72c229a77ea502deca60bb3209
Gerrit-Change-Number: 17822
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Tue, 31 Aug 2021 23:40:57 +0000
Gerrit-HasComments: No