You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2018/12/23 18:44:00 UTC

[jira] [Comment Edited] (HBASE-21629) draining_servers.rb is broken

    [ https://issues.apache.org/jira/browse/HBASE-21629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728031#comment-16728031 ] 

stack edited comment on HBASE-21629 at 12/23/18 6:43 PM:
---------------------------------------------------------

+1 on patch.

Paste in here evidence it works (perhaps a before and after [~nihaljain.cs]?) Thank you.


was (Author: stack):
+1 on patch.

Past in here evidence it works (perhaps a before and after [~nihaljain.cs]?) Thank you.

> draining_servers.rb is broken
> -----------------------------
>
>                 Key: HBASE-21629
>                 URL: https://issues.apache.org/jira/browse/HBASE-21629
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 3.0.0, 2.1.1, 2.1.2
>            Reporter: Nihal Jain
>            Assignee: Nihal Jain
>            Priority: Major
>         Attachments: HBASE-21629.master.001.patch
>
>
> 1) Handle missing methods and implementation changes in core code.
>  * In [ZKWatcher.java|https://github.com/apache/hbase/blob/12786f80c14c6f2c3c111a55bbf431fb2e81e828/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java#L79], variable znodePaths has now been made private from public (See HBASE-19761). Currently the script directly tries to reference znodePaths which will result in exception.
>  * Also, joinZNode method is moved to ZNodePaths and removed from ZKUtil (See HBASE-19200). The script relies on non-existant ZKUtil.joinZNode().
> 2) Close zk watcher while list draining servers: The list functionality does not close the zkw instance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)