You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/10 04:13:59 UTC
[jira] [Commented] (BEAM-954) FileBasedSink: remove unused code of
TemporaryFileRetention
[ https://issues.apache.org/jira/browse/BEAM-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15652974#comment-15652974 ]
ASF GitHub Bot commented on BEAM-954:
-------------------------------------
GitHub user peihe opened a pull request:
https://github.com/apache/incubator-beam/pull/1331
[BEAM-954] FileBasedSink: remove unused code of TemporaryFileRetention.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/peihe/incubator-beam rm-retention
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1331.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1331
----
commit 6871feaf22da2384b37ed09ac9c5a47a9a5dced6
Author: Pei He <pe...@google.com>
Date: 2016-11-10T04:12:24Z
[BEAM-954] FileBasedSink: remove unused code of TemporaryFileRetention.
----
> FileBasedSink: remove unused code of TemporaryFileRetention
> -----------------------------------------------------------
>
> Key: BEAM-954
> URL: https://issues.apache.org/jira/browse/BEAM-954
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core, sdk-java-gcp
> Reporter: Pei He
> Assignee: Pei He
>
> TemporaryFileRetention option is not used.
> Removing it will simplify the redesign of IOChannelFactory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)