You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/06/11 12:20:02 UTC

[GitHub] [couchdb] big-r81 opened a new pull request, #4060: Add Erlang 25 support

big-r81 opened a new pull request, #4060:
URL: https://github.com/apache/couchdb/pull/4060

   Before merging this PR, PR [#16](https://github.com/apache/couchdb-snappy/pull/16) in couchdb-snappy needs to get merged and tagged with CouchDB-1.0.8
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] nickva commented on pull request #4060: Add Erlang 25 support

Posted by GitBox <gi...@apache.org>.
nickva commented on PR #4060:
URL: https://github.com/apache/couchdb/pull/4060#issuecomment-1154425919

   I think it's the http_uri:parse/1 function:
   
   24
   ```
   1> http_uri:parse("https://foo:bar@zig.zag/abc?param1").
   {ok,{https,"foo:bar","zig.zag",443,"/abc","?param1"}}
   ```
   
   25
   ```
   1> http_uri:parse("https://foo:bar@zig.zag/abc?param1").
   ** exception error: undefined function http_uri:parse/1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] nickva commented on pull request #4060: Add Erlang 25 support

Posted by GitBox <gi...@apache.org>.
nickva commented on PR #4060:
URL: https://github.com/apache/couchdb/pull/4060#issuecomment-1154391783

   Most tests pass but I had noticed a few eunit failures locally. We'd probably want to add some ifdefs around there or switch to https://www.erlang.org/docs/25/man/uri_string.html
   
   ```
   in function couch_replicator_error_reporting_tests:'-t_fail_bulk_docs/1-fun-1-'/2 (test/eunit/couch_replicator_error_reporting_tests.erl, line 68)
   in call from eunit_test:run_testfun/1 (eunit_test.erl, line 71)
   in call from eunit_proc:run_test/1 (eunit_proc.erl, line 531)
   in call from eunit_proc:with_timeout/3 (eunit_proc.erl, line 356)
   in call from eunit_proc:handle_test/2 (eunit_proc.erl, line 514)
   in call from eunit_proc:tests_inorder/3 (eunit_proc.erl, line 456)
   in call from eunit_proc:with_timeout/3 (eunit_proc.erl, line 346)
   in call from eunit_proc:run_group/2 (eunit_proc.erl, line 570)
   **error:{assertEqual,
       [{module,couch_replicator_error_reporting_tests},
        {line,68},
        {expression,"Result"},
        {expected,{bulk_docs_failed,403,{[{<<"x">>,<<"y">>}]}}},
        {value,
            {worker_died,<0.9144.0>,
                {process_died,<0.9145.0>,{undef,[{http_uri,...},{...}|...]}}}}]}
     output:<<"">>
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] big-r81 merged pull request #4060: Add Erlang 25 support

Posted by GitBox <gi...@apache.org>.
big-r81 merged PR #4060:
URL: https://github.com/apache/couchdb/pull/4060


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org