You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/03/13 00:08:39 UTC
Review Request 66031: Avoided copying when possible in
Option::getOrElse.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66031/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
This mimics the behavior of std::optional::value_or.
Diffs
-----
3rdparty/stout/include/stout/option.hpp 72403e770afbb59bd1c58b621c2bc566de3cd979
Diff: https://reviews.apache.org/r/66031/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 66031: Avoided copying when possible in
Option::getOrElse.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66031/#review199046
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On March 12, 2018, 5:08 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66031/
> -----------------------------------------------------------
>
> (Updated March 12, 2018, 5:08 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This mimics the behavior of std::optional::value_or.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/option.hpp 72403e770afbb59bd1c58b621c2bc566de3cd979
>
>
> Diff: https://reviews.apache.org/r/66031/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>