[GitHub] wohali commented on a change in pull request #27: vm.args is now editable -- enabling clusters; snap set works for name and cookie

[GitBox <gi...@apache.org>]

wohali commented on a change in pull request #27: vm.args is now editable -- enabling clusters; snap set works for name and cookie 
URL: https://github.com/apache/couchdb-pkg/pull/27#discussion_r226721501
 
 

 ##########
 File path: snap/snapcraft.yaml
 ##########
 @@ -9,17 +9,17 @@ apps:
     server:
         daemon: simple
         command: rel/couchdb/bin/snap_run
-        plugs: [network-bind, process-control, mount-observe, browser-support]
+        plugs: [network-bind, process-control, mount-observe]
     couchdb:
         command: rel/couchdb/bin/snap_run
-        plugs: [network-bind]
+        plugs: [network-bind,browser-support]
 parts:
     couchdb: 
         plugin: make
-        #source: http://www-us.apache.org/dist/couchdb/source/2.0.0/apache-couchdb-2.0.0.tar.gz
-        source: https://github.com/apache/couchdb.git
-        source-type: git
-        source-tag: 2.1.0
+        source: http://www-us.apache.org/dist/couchdb/source/2.2.0/apache-couchdb-2.2.0.tar.gz
+        #source: https://github.com/apache/couchdb.git
 
 Review comment:
   Actually, GitHub is the master, surprisingly. You can leave this as it was.
   
   BUT.
   
   It would be best if you can switch to using our tarball releases instead - if you do this, you don't need a bunch of build dependencies (no node/npm, no sphinx) and the build goes a lot faster.
   
   Tarball releases are here: https://www-us.apache.org/dist/couchdb/source/<release number>/
   
   The advantage to switching to this download approach is that you can pull the GPG key and a SHA256/SHA512 to ensure you have the correct build. If you're curious how to do this, check out our [Dockerfile](https://github.com/apache/couchdb-docker/blob/master/2.2.0/Dockerfile#L126-L140) which has an example script doing precisely that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services