[Impala-ASF-CR] IMPALA-10766: Better selectivity for =,not distinct

["Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>]

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17637 )

Change subject: IMPALA-10766: Better selectivity for =,not distinct
......................................................................


Patch Set 4: Code-Review+1

(3 comments)

Found a few nits, but otherwise LGTM.

http://gerrit.cloudera.org:8080/#/c/17637/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17637/4//COMMIT_MSG@20
PS4, Line 20: Tesing
Testing


http://gerrit.cloudera.org:8080/#/c/17637/4/fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java
File fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java:

http://gerrit.cloudera.org:8080/#/c/17637/4/fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java@253
PS4, Line 253: =
!=


http://gerrit.cloudera.org:8080/#/c/17637/4/fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java@283
PS4, Line 283: slotDesc.getStats().getNumNulls()
nit: I think it's worth to extract it to a variable just like numRows



-- 
To view, visit http://gerrit.cloudera.org:8080/17637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8ec62f2355a7036125cc0d261b790644b9f4b60
Gerrit-Change-Number: 17637
Gerrit-PatchSet: 4
Gerrit-Owner: liuyao <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Jul 2021 08:23:52 +0000
Gerrit-HasComments: Yes