You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/30 16:45:17 UTC

[GitHub] [superset] RossMoir opened a new issue #15478: [Explore] Server pagination is not working

RossMoir opened a new issue #15478:
URL: https://github.com/apache/superset/issues/15478


   Server side pagination has no effect. The server side pagination option for the table chart correctly retrieves the first page of results but the page jumps will not respond to inputs. Issue #14727 shows similar experiences but was closed however the effect remains in Superset `1.2`.
   
   ### Expected results
   
   On new page selection the next 10 results should be shown.
   
   ### Actual results
   
   On new page selection the table stays on the first page and no new queries are conducted.
   
   https://user-images.githubusercontent.com/44472119/123997942-d7ac1e00-d9c8-11eb-93ac-ea5ded370b7d.mov
   
   #### How to reproduce the bug
   
   1. Launch Superset 1.2 with a connected Apache Druid 0.21.1 database.
   2. Create a Table from the Druid dataset.
   3. Enable 'Server Pagination'
   4. See error
   
   ### Environment
   
   (please complete the following information):
   
   - superset version: `1.2`
   - druid version: `0.21.1`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] RossMoir commented on issue #15478: [Explore] Server pagination is not working

Posted by GitBox <gi...@apache.org>.
RossMoir commented on issue #15478:
URL: https://github.com/apache/superset/issues/15478#issuecomment-880205165


   > For my case this is very relevant features so if can fix if would be amazing.
   
   Completely agree, this is high priority for our use case. Any use of larger queries benefit greatly from server-side pagination and a fix would be extremely appreciated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #15478: [Explore] Server pagination is not working

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15478:
URL: https://github.com/apache/superset/issues/15478#issuecomment-879408791


   verify fixed on master @aelich @RossMoir 
   https://user-images.githubusercontent.com/67837651/125526154-5676e608-d100-4485-837b-7ad2fed61aa0.mov
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #15478: [Explore] Server pagination is not working

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15478:
URL: https://github.com/apache/superset/issues/15478#issuecomment-871815135


   This issue has been fixed, however... it introduce a new issue - the pagination disappear entirely.... @jinghua-qa please double check 🙏
   
   https://user-images.githubusercontent.com/67837651/124046859-bf87cf00-d9c7-11eb-8f8e-101c0cfcac25.mov
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc edited a comment on issue #15478: [Explore] Server pagination is not working

Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #15478:
URL: https://github.com/apache/superset/issues/15478#issuecomment-879408791


   verify fixed on master @aelich @RossMoir 
   
   https://user-images.githubusercontent.com/67837651/125526213-a97552b8-e5fc-4325-a0a5-c11eb56f2ed0.mov
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] aelich commented on issue #15478: [Explore] Server pagination is not working

Posted by GitBox <gi...@apache.org>.
aelich commented on issue #15478:
URL: https://github.com/apache/superset/issues/15478#issuecomment-880453806


   @RossMoir  I think we need to make one more issue, I dont think this one will re-open this one again, can you please make it (as I dont have videos) and i'll support you on new issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] aelich commented on issue #15478: [Explore] Server pagination is not working

Posted by GitBox <gi...@apache.org>.
aelich commented on issue #15478:
URL: https://github.com/apache/superset/issues/15478#issuecomment-880161762


   @junlincc please don’t close its still broken, just tried it. (When you don't click on server pagination, like you have shown in last video, superset makes one big query and transfer all the data at once so when you click on buttons its just pagination and data is already in browser...)
   
   @RossMoir I totally support you and confirmed it, its still broken i tried master branch on mysql and postgres few min ago its still broken!
   
   For my case this is very relevant features so if can fix if would be amazing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] aelich commented on issue #15478: [Explore] Server pagination is not working

Posted by GitBox <gi...@apache.org>.
aelich commented on issue #15478:
URL: https://github.com/apache/superset/issues/15478#issuecomment-878522564


   Hi guys 
   
   I have the same issue just with postgres DB, any hint how to fix, please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc closed issue #15478: [Explore] Server pagination is not working

Posted by GitBox <gi...@apache.org>.
junlincc closed issue #15478:
URL: https://github.com/apache/superset/issues/15478


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] RossMoir commented on issue #15478: [Explore] Server pagination is not working

Posted by GitBox <gi...@apache.org>.
RossMoir commented on issue #15478:
URL: https://github.com/apache/superset/issues/15478#issuecomment-879761261


   @junlincc Trying this out on master it is still broken. Your video doesn't have 'Server Pagination' enabled, notice the number of rows and the option on the left is disabled, this means only a single query is made not a new one for each page flip. Please reopen this issue as it remains broken. @aelich can you confirm?
   
   https://user-images.githubusercontent.com/44472119/125602810-3e2c065e-f255-4f81-866f-abb99403b641.mov
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org