[jira] [Work logged] (GOBBLIN-1519) Simplify `InstrumentedSpecStore` implementation by DRYing up operation timing

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1519?focusedWorklogId=638962&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-638962 ]

ASF GitHub Bot logged work on GOBBLIN-1519:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Aug/21 03:10
            Start Date: 18/Aug/21 03:10
    Worklog Time Spent: 10m 
      Work Description: phet opened a new pull request #3369:
URL: https://github.com/apache/gobblin/pull/3369


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references it in the PR title:
       - https://issues.apache.org/jira/browse/GOBBLIN-1519
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if applicable):
   
   this is an internal, implementation-level refactoring that should not modify externally-observable behavior.  it was motivated by the repetitive, near boiler plate for timing each operation in `InstrumentedSpecStore`, as noticed in the recent PR - https://github.com/apache/gobblin/pull/3367 .  it:
   
   * simplifies that class by DRYing it up through a companion helper class.
   * preserves method signatures for source compatibility
   * measures nanoseconds, rather than milliseconds, since that is what `metrics.Timer` trades in internally
   
   the only *change* is:
   
   * the newly-added `SpecStore.getSize()` call is now recorded with the suffix `"-GETCOUNT"`, to discern it from `"-GETALL"`, which it previously used, although the latter was found to be already in use for a different operation - https://github.com/apache/gobblin/pull/3367#discussion_r690792043
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   existing unit tests, such as `org.apache.gobblin.runtime.spec_store.FSSpecStoreTest.testGetSpecURI`, exercise refactoring and continue to pass
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 638962)
    Remaining Estimate: 0h
            Time Spent: 10m

> Simplify `InstrumentedSpecStore` implementation by DRYing up operation timing
> -----------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1519
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1519
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Kip Kohn
>            Priority: Trivial
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)