You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/09/29 10:16:15 UTC
Review Request 62687: Added utility function to get data from a master
endpoint to CLI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62687/
-----------------------------------------------------------
Review request for mesos and Kevin Klues.
Repository: mesos
Description
-------
This removes the similar code that had CLI plugins.
Diffs
-----
src/python/cli_new/lib/cli/plugins/agent/main.py PRE-CREATION
src/python/cli_new/lib/cli/plugins/task/main.py PRE-CREATION
src/python/cli_new/lib/cli/util.py 7371f83543ed527bea8dbf2fe4e20d92ef8e4492
Diff: https://reviews.apache.org/r/62687/diff/1/
Testing
-------
To test with one master:
```
$ ./bootstrap
$ source activate
$ mesos-cli-tests
```
I also checked that the Python linter was still working.
Thanks,
Armand Grillet
Re: Review Request 62687: Added utility function to get data from a
master endpoint to CLI.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62687/#review186760
-----------------------------------------------------------
Bad patch!
Reviews applied: [62687, 62663]
Failed command: python support/apply-reviews.py -n -r 62687
Error:
2017-09-30 00:10:30 URL:https://reviews.apache.org/r/62687/diff/raw/ [6979/6979] -> "62687.patch" [1]
error: patch failed: src/python/cli_new/lib/cli/util.py:155
error: src/python/cli_new/lib/cli/util.py: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/19632/console
- Mesos Reviewbot
On Sept. 29, 2017, 10:16 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62687/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2017, 10:16 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This removes the similar code that had CLI plugins.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/plugins/agent/main.py PRE-CREATION
> src/python/cli_new/lib/cli/plugins/task/main.py PRE-CREATION
> src/python/cli_new/lib/cli/util.py 7371f83543ed527bea8dbf2fe4e20d92ef8e4492
>
>
> Diff: https://reviews.apache.org/r/62687/diff/1/
>
>
> Testing
> -------
>
> To test with one master:
> ```
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
> ```
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62687: Added utility function to get data from a
master endpoint to CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62687/#review186660
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 62663.
Failed command: `python.exe .\support\apply-reviews.py -n -r 62663`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62687
Relevant logs:
- [apply-review-62663-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62687/logs/apply-review-62663-stdout.log):
```
error: patch failed: src/python/pylint.config:28
error: src/python/pylint.config: patch does not apply
```
- Mesos Reviewbot Windows
On Sept. 29, 2017, 10:16 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62687/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2017, 10:16 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This removes the similar code that had CLI plugins.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/plugins/agent/main.py PRE-CREATION
> src/python/cli_new/lib/cli/plugins/task/main.py PRE-CREATION
> src/python/cli_new/lib/cli/util.py 7371f83543ed527bea8dbf2fe4e20d92ef8e4492
>
>
> Diff: https://reviews.apache.org/r/62687/diff/1/
>
>
> Testing
> -------
>
> To test with one master:
> ```
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
> ```
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>