You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/08/24 23:59:46 UTC

Review Request 61904: Added volume/host_path isolator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61904/
-----------------------------------------------------------

Review request for mesos, Gilbert Song and Joseph Wu.


Bugs: MESOS-7306
    https://issues.apache.org/jira/browse/MESOS-7306


Repository: mesos


Description
-------

This isolator will be used to handle HOST_PATH volumes. The goal is to
move the logics of handling host volumes from the linux filesystem
isolator to this dedicated isolator to make the code more modular.


Diffs
-----

  src/CMakeLists.txt 0816c6ebaa9caaa5b6a606e601427ed17112a300 
  src/Makefile.am 5157b2baac4ff6c4493faaeb7a311381e8e76fe7 
  src/slave/containerizer/mesos/isolators/volume/host_path.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/volume/host_path.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/61904/diff/1/


Testing
-------

sudo make check


Thanks,

Jie Yu

Re: Review Request 61904: Added volume/host_path isolator.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61904/#review183978
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/volume/host_path.cpp
Lines 100-101 (patched)
<https://reviews.apache.org/r/61904/#comment260017>

    Perhaps expand on this note?
    
    i.e. If an old master (no validation code) is used to launch a task with a volume.



src/slave/containerizer/mesos/isolators/volume/host_path.cpp
Lines 108-111 (patched)
<https://reviews.apache.org/r/61904/#comment260019>

    Consider adding a NOTE here about why it is *not* an error for `volume.host_path` to be relative (even though it is an error in `volume.source().host_path()`).


- Joseph Wu


On Aug. 28, 2017, 1:26 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61904/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2017, 1:26 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Joseph Wu.
> 
> 
> Bugs: MESOS-7223 and MESOS-7306
>     https://issues.apache.org/jira/browse/MESOS-7223
>     https://issues.apache.org/jira/browse/MESOS-7306
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This isolator will be used to handle HOST_PATH volumes. The goal is to
> move the logics of handling host volumes from the linux filesystem
> isolator to this dedicated isolator to make the code more modular.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 0816c6ebaa9caaa5b6a606e601427ed17112a300 
>   src/Makefile.am 5157b2baac4ff6c4493faaeb7a311381e8e76fe7 
>   src/slave/containerizer/mesos/isolators/volume/host_path.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/volume/host_path.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61904/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 61904: Added volume/host_path isolator.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61904/
-----------------------------------------------------------

(Updated Aug. 28, 2017, 8:26 p.m.)


Review request for mesos, Gilbert Song and Joseph Wu.


Bugs: MESOS-7223 and MESOS-7306
    https://issues.apache.org/jira/browse/MESOS-7223
    https://issues.apache.org/jira/browse/MESOS-7306


Repository: mesos


Description
-------

This isolator will be used to handle HOST_PATH volumes. The goal is to
move the logics of handling host volumes from the linux filesystem
isolator to this dedicated isolator to make the code more modular.


Diffs
-----

  src/CMakeLists.txt 0816c6ebaa9caaa5b6a606e601427ed17112a300 
  src/Makefile.am 5157b2baac4ff6c4493faaeb7a311381e8e76fe7 
  src/slave/containerizer/mesos/isolators/volume/host_path.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/volume/host_path.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/61904/diff/1/


Testing
-------

sudo make check


Thanks,

Jie Yu