[GitHub] rdhabalia commented on a change in pull request #1953: [bookie-http-server] Fix: broken vertx rest endpoints

[GitBox <gi...@apache.org>]

rdhabalia commented on a change in pull request #1953: [bookie-http-server] Fix: broken vertx rest endpoints
URL: https://github.com/apache/bookkeeper/pull/1953#discussion_r258295618
 
 

 ##########
 File path: bookkeeper-http/vertx-http-server/src/main/java/org/apache/bookkeeper/http/vertx/VertxHttpServer.java
 ##########
 @@ -70,6 +70,9 @@ public boolean startServer(int port) {
             @Override
             public void bindHandler(String endpoint, VertxAbstractHandler handler) {
                 router.get(endpoint).handler(handler);
+                router.put(endpoint).handler(handler);
 
 Review comment:
   I think test only covers get and not the put. I will add test for triggering gc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services