You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by as...@apache.org on 2021/11/24 12:53:03 UTC
[camel-k] 15/19: fix(lint): rename StrimziBindingProvider
This is an automated email from the ASF dual-hosted git repository.
astefanutti pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel-k.git
commit 25a10c63bd3ff94e279e716266c90e8724622272
Author: Luca Burgazzoli <lb...@gmail.com>
AuthorDate: Tue Nov 23 00:20:51 2021 +0100
fix(lint): rename StrimziBindingProvider
---
addons/register_strimzi.go | 2 +-
addons/strimzi/strimzi.go | 13 ++++++-------
addons/strimzi/strimzi_test.go | 4 ++--
3 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/addons/register_strimzi.go b/addons/register_strimzi.go
index 9eac795..de9c90d 100644
--- a/addons/register_strimzi.go
+++ b/addons/register_strimzi.go
@@ -23,5 +23,5 @@ import (
)
func init() {
- bindings.RegisterBindingProvider(strimzi.StrimziBindingProvider{})
+ bindings.RegisterBindingProvider(strimzi.BindingProvider{})
}
diff --git a/addons/strimzi/strimzi.go b/addons/strimzi/strimzi.go
index a8329af..5d2413a 100644
--- a/addons/strimzi/strimzi.go
+++ b/addons/strimzi/strimzi.go
@@ -30,17 +30,16 @@ import (
"k8s.io/apimachinery/pkg/runtime/schema"
)
-// StrimziBindingProvider allows to connect to a Kafka topic via KameletBinding
-// nolint: revive
-type StrimziBindingProvider struct {
+// BindingProvider allows to connect to a Kafka topic via KameletBinding
+type BindingProvider struct {
Client internalclientset.Interface
}
-func (s StrimziBindingProvider) ID() string {
+func (s BindingProvider) ID() string {
return "strimzi"
}
-func (s StrimziBindingProvider) Translate(ctx bindings.BindingContext, _ bindings.EndpointContext, endpoint v1alpha1.Endpoint) (*bindings.Binding, error) {
+func (s BindingProvider) Translate(ctx bindings.BindingContext, _ bindings.EndpointContext, endpoint v1alpha1.Endpoint) (*bindings.Binding, error) {
if endpoint.Ref == nil {
// React only on refs
return nil, nil
@@ -100,7 +99,7 @@ func (s StrimziBindingProvider) Translate(ctx bindings.BindingContext, _ binding
}, nil
}
-func (s StrimziBindingProvider) getBootstrapServers(ctx bindings.BindingContext, clusterName string) (string, error) {
+func (s BindingProvider) getBootstrapServers(ctx bindings.BindingContext, clusterName string) (string, error) {
cluster, err := s.Client.KafkaV1beta2().Kafkas(ctx.Namespace).Get(ctx.Ctx, clusterName, v1.GetOptions{})
if err != nil {
return "", err
@@ -119,6 +118,6 @@ func (s StrimziBindingProvider) getBootstrapServers(ctx bindings.BindingContext,
return "", fmt.Errorf("cluster %q has no listeners of type %q", clusterName, v1beta2.StrimziListenerTypePlain)
}
-func (s StrimziBindingProvider) Order() int {
+func (s BindingProvider) Order() int {
return bindings.OrderStandard
}
diff --git a/addons/strimzi/strimzi_test.go b/addons/strimzi/strimzi_test.go
index 34b9d08..1ef679d 100644
--- a/addons/strimzi/strimzi_test.go
+++ b/addons/strimzi/strimzi_test.go
@@ -58,7 +58,7 @@ func TestStrimziDirect(t *testing.T) {
}),
}
- binding, err := StrimziBindingProvider{}.Translate(bindingContext, bindings.EndpointContext{
+ binding, err := BindingProvider{}.Translate(bindingContext, bindings.EndpointContext{
Type: v1alpha1.EndpointTypeSink,
}, endpoint)
assert.NoError(t, err)
@@ -100,7 +100,7 @@ func TestStrimziLookup(t *testing.T) {
}
client := fake.NewSimpleClientset(&cluster, &topic)
- provider := StrimziBindingProvider{
+ provider := BindingProvider{
Client: client,
}