You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Swarnim Kulkarni <ku...@gmail.com> on 2015/08/07 06:43:59 UTC

Review Request 37207: HIVE-5277 Fix for wrong hbase counts

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37207/
-----------------------------------------------------------

Review request for hive, Ashutosh Chauhan and Xuefu Zhang.


Repository: hive-git


Description
-------

HIVE-5277 Fix for wrong hbase counts


Diffs
-----

  hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseInputFormatUtil.java 05245728ba7ad8579554d44ff6abad61db89ed16 
  hbase-handler/src/test/queries/positive/hbase_null_first_col.q PRE-CREATION 
  hbase-handler/src/test/results/positive/hbase_null_first_col.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/37207/diff/


Testing
-------

Added tests as well as tested manually that it fixes the issue.


Thanks,

Swarnim Kulkarni

Re: Review Request 37207: HIVE-5277 Fix for wrong hbase counts

Posted by Xuefu Zhang <xz...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37207/#review94982
-----------------------------------------------------------

Ship it!


Ship It!

- Xuefu Zhang


On Aug. 7, 2015, 4:43 a.m., Swarnim Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37207/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2015, 4:43 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Xuefu Zhang.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-5277 Fix for wrong hbase counts
> 
> 
> Diffs
> -----
> 
>   hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseInputFormatUtil.java 05245728ba7ad8579554d44ff6abad61db89ed16 
>   hbase-handler/src/test/queries/positive/hbase_null_first_col.q PRE-CREATION 
>   hbase-handler/src/test/results/positive/hbase_null_first_col.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37207/diff/
> 
> 
> Testing
> -------
> 
> Added tests as well as tested manually that it fixes the issue.
> 
> 
> Thanks,
> 
> Swarnim Kulkarni
> 
>