You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "aminghadersohi (via GitHub)" <gi...@apache.org> on 2026/10/14 08:53:46 UTC
Re: [PR] docs(reports): document retry-on-failure behavior for reports [superset]
aminghadersohi commented on code in PR #43903:
URL: https://github.com/apache/superset/pull/43903#discussion_r4268698165
##########
docs/admin_docs/configuration/alerts-reports.mdx:
##########
@@ -472,6 +472,72 @@ ALERT_REPORTS_ENABLE_LINK_REDIRECT = False
The feature uses `WEBDRIVER_BASEURL_USER_FRIENDLY` (or `WEBDRIVER_BASEURL`)
to determine which hosts are internal.
+## Retry on Failure
+
+This feature is gated behind the `ALERT_REPORTS_RETRY` feature flag, which is
+disabled by default:
+
+```python
+FEATURE_FLAGS = {
+ "ALERT_REPORTS_RETRY": True,
+}
+```
+
+With the flag enabled, reports (not alerts) can be configured to
Review Comment:
https://github.com/apache/superset/pull/44336 deleted the `Retries are not supported for alerts` validator from `superset/reports/schemas.py`, and `AlertReportModal.tsx:3241` renders Enable Retries, so alerts do retry on master.
```suggestion
With the flag enabled, alerts and reports can be configured to
```
##########
docs/admin_docs/configuration/alerts-reports.mdx:
##########
@@ -472,6 +472,72 @@ ALERT_REPORTS_ENABLE_LINK_REDIRECT = False
The feature uses `WEBDRIVER_BASEURL_USER_FRIENDLY` (or `WEBDRIVER_BASEURL`)
to determine which hosts are internal.
+## Retry on Failure
+
+This feature is gated behind the `ALERT_REPORTS_RETRY` feature flag, which is
+disabled by default:
+
+```python
+FEATURE_FLAGS = {
+ "ALERT_REPORTS_RETRY": True,
+}
+```
+
+With the flag enabled, reports (not alerts) can be configured to
+automatically retry when sending fails — this covers rendering/export
+failures (e.g. a chart screenshot or CSV export erroring out) as well as
+delivery failures such as a transient SMTP or Slack error — instead of
Review Comment:
`_delivery_started` is set at `execute.py:1788`, one line before `_send_notification`, and the guard at `:2097` returns False on it, so an SMTP/Slack error is never retried. Master's own line 673 states this.
```suggestion
automatically retry when execution fails — this covers rendering/export
failures (e.g. a chart screenshot or CSV export erroring out), but not
delivery failures, since a provider may have accepted the notification
before returning an error — instead of
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org