You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/15 11:13:10 UTC
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #425: Fix unmanage / manager cluster
davidjumani opened a new pull request #425:
URL: https://github.com/apache/cloudstack-primate/pull/425
Fixes #396
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #425: Fix unmanage / manager cluster
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #425:
URL: https://github.com/apache/cloudstack-primate/pull/425#issuecomment-645171976
@rhtyd Good catch! Changes made!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #425: Fix unmanage / manager cluster
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #425:
URL: https://github.com/apache/cloudstack-primate/pull/425#issuecomment-645238708
@davidjumani see we could further simply it as the allocation state will able be either Enabled or Disabled (see Cluster.java/enums)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #425: Fix unmanage / manager cluster
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #425:
URL: https://github.com/apache/cloudstack-primate/pull/425#issuecomment-645167873
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #425: Fix unmanage / manager cluster
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #425:
URL: https://github.com/apache/cloudstack-primate/pull/425#issuecomment-644639604
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/425 (JID-2016)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #425: Fix unmanage / manager cluster
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #425:
URL: https://github.com/apache/cloudstack-primate/pull/425#issuecomment-644635261
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #425: Fix unmanage / manager cluster
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #425:
URL: https://github.com/apache/cloudstack-primate/pull/425#issuecomment-645152399
The check can be based on record.managedstate and record.allocationstate to show/hide the buttons
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #425: Fix unmanage / manager cluster
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #425:
URL: https://github.com/apache/cloudstack-primate/pull/425#issuecomment-645171047
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/425 (JID-2025)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #425: Fix unmanage / manager cluster
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #425:
URL: https://github.com/apache/cloudstack-primate/pull/425#issuecomment-645152148
@davidjumani it gets a bit complicated as the state itself is determined as follows, legacy code reference:
```
if (jsonObj.managedstate == "Managed") {
jsonObj.state = jsonObj.allocationstate; //jsonObj.state == Enabled, Disabled
} else {
jsonObj.state = jsonObj.managedstate; //jsonObj.state == Unmanaged, PrepareUnmanaged, PrepareUnmanagedError
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #425: Fix unmanage / manager cluster
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #425:
URL: https://github.com/apache/cloudstack-primate/pull/425#issuecomment-644634634
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #425: Fix unmanage / manager cluster
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #425:
URL: https://github.com/apache/cloudstack-primate/pull/425#issuecomment-645168311
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #425: Fix unmanage / manager cluster
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #425:
URL: https://github.com/apache/cloudstack-primate/pull/425#issuecomment-645147556
@rhtyd ready to go!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #425: Fix unmanage / manager cluster
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #425:
URL: https://github.com/apache/cloudstack-primate/pull/425
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org