[GitHub] [incubator-linkis] casionone commented on a diff in pull request #3588: [flink ]module errorcode optimization and documentation

[GitBox <gi...@apache.org>]

casionone commented on code in PR #3588:
URL: https://github.com/apache/incubator-linkis/pull/3588#discussion_r995533855


##########
linkis-engineconn-plugins/flink/src/main/java/org/apache/linkis/engineconnplugin/flink/client/config/Environment.java:
##########
@@ -102,9 +102,7 @@ public void setCatalogs(List<Map<String, Object>> catalogs) throws FlinkInitFail
       final CatalogEntry catalog = CatalogEntry.create(config);
       if (this.catalogs.containsKey(catalog.getName())) {
         throw new FlinkInitFailedException(
-            String.format(
-                "Cannot create catalog '%s' because a catalog with this name is already registered.",
-                catalog.getName()));
+            String.format(CANNOT_CATALOG_ALREADY.getErrorDesc(), catalog.getName()));

Review Comment:
   important information will be lost  if delete  '%s' 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org