[GitHub] [flink] luoyuxia commented on a diff in pull request #19931: [FLINK-27999][hive] Fix test failure for Hive when using profile Hive3.1.1

[GitBox <gi...@apache.org>]

luoyuxia commented on code in PR #19931:
URL: https://github.com/apache/flink/pull/19931#discussion_r894604477


##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserBaseSemanticAnalyzer.java:
##########
@@ -387,7 +387,9 @@ private static void processPrimaryKeyInfos(HiveParserASTNode pkNode, List<PKInfo
     }
 
     private static void checkColumnName(String columnName) throws SemanticException {
-        if (VirtualColumn.VIRTUAL_COLUMN_NAMES.contains(columnName.toUpperCase())) {

Review Comment:
   It's really wired to me. It'wll throw `java.lang.NoSuchFieldError: VIRTUAL_COLUMN_NAMES` with this line [fail](https://github.com/apache/flink/pull/19926) . 
   But it does exist in `VirtualColumn`.
   And It's fine in Flink 1.15.0, so I believe some changes to master boils it.
   So i change this line, and then the change is fine.Sucessful test is in [here](https://github.com/apache/flink/pull/19929)
   Also, I validate it by flink sql client.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org