You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "michallenc (via GitHub)" <gi...@apache.org> on 2025/02/19 15:20:49 UTC
[PR] lcd/st7789: fix incorrect buffer count for 3 wire RAM write [nuttx]
michallenc opened a new pull request, #15873:
URL: https://github.com/apache/nuttx/pull/15873
## Summary
If `st7789_wrram` is called with `count = 1`, then the entire buffer should be sent. However, in 3 wire mode, the driver has to send the buffer row by row because of additional data flag. The number of rows (count) can't be `ST7789_YRES` in this case, but only the number of rows in the buffer (this is write size / row size , where row size is `ST7789_XRES * ST7789_BYTESPP`). This also applies only if we want to write size larger than row size, because `st7789_putrun` allows to write just a part of a row.
This fixes the incorrect behavior of the display in 3 wire mode if the display is split into more buffer writes (as in LCD driver for example, FB driver did not face this issue).
## Impact
Fixes the behavior of the display with LCD driver if the buffer is less than the entire display size (usually the case in LVGL library). This was initially my fault when introducing the support for 3 wire communication, I had done tests only with FB driver back then and there was no issue with FB driver.
## Testing
Tested with 3 scenarios:
- multiple buffers, each 60 rows large (against LVGL), LCD driver
- single buffer for the entire display, LCD driver
- FB driver
Tested on 320 x 240 large display connected as 3 wire on SPI bus with DMA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] lcd/st7789: fix incorrect buffer count for 3 wire RAM write [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl merged PR #15873:
URL: https://github.com/apache/nuttx/pull/15873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] lcd/st7789: fix incorrect buffer count for 3 wire RAM write [nuttx]
Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #15873:
URL: https://github.com/apache/nuttx/pull/15873#issuecomment-2668979940
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
Yes, this PR appears to meet the NuttX requirements, although some minor additions could strengthen it.
Here's a breakdown:
**Strengths:**
* **Clear Summary:** Explains the bug, the fix, and the specific scenario where it matters.
* **Specific Impact:** Clearly outlines the user-facing consequences of the bug and the fix. The mention of LVGL is helpful context.
* **Relevant Testing:** Describes the testing scenarios, including different buffer sizes and drivers, and specifies the hardware configuration.
**Areas for Improvement (Minor):**
* **Missing Links:** The Summary section mentions this fixing incorrect behavior, but doesn't link to a NuttX issue. Even if one doesn't exist, consider creating one to track the bug and link it to the PR.
* **Missing Build Host/Target Details:** While the testing section describes the *hardware target*, it lacks information about the *build host* (OS, compiler, etc.) as required by the template. Adding these details enhances reproducibility.
* **Absent Log Snippets:** The template requests "Testing logs before change" and "Testing logs after change." Include relevant snippets to demonstrate the fix in action. Even a brief "before: garbled output; after: correct output" is better than nothing. Visual evidence (e.g., photos of the display before/after) could also be very helpful.
* **Consider "Impact" Sections:** While the impact is clear, explicitly stating "NO" for the unaffected categories (build process, hardware changes, documentation, security, compatibility) in the Impact section makes the review easier. If something *is* affected (e.g., if you needed to add a config option), those details should be described.
By adding these minor details, you can make your PR even stronger and easier for reviewers to assess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] lcd/st7789: fix incorrect buffer count for 3 wire RAM write [nuttx]
Posted by "michallenc (via GitHub)" <gi...@apache.org>.
michallenc commented on PR #15873:
URL: https://github.com/apache/nuttx/pull/15873#issuecomment-2676762816
@acassis @lupyuen Hi, is it ok to merge now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] lcd/st7789: fix incorrect buffer count for 3 wire RAM write [nuttx]
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #15873:
URL: https://github.com/apache/nuttx/pull/15873#issuecomment-2677322205
Sorry @cederom do we need any more reviews for this? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org