You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/03/29 11:33:20 UTC

[GitHub] rnewson commented on a change in pull request #1253: [DISCUSS] Validate new document writes against max_http_request_size

rnewson commented on a change in pull request #1253: [DISCUSS] Validate new document writes against max_http_request_size
URL: https://github.com/apache/couchdb/pull/1253#discussion_r178028228
 
 

 ##########
 File path: src/couch/src/couch_att.erl
 ##########
 @@ -708,6 +709,9 @@ upgrade(#att{} = Att) ->
 upgrade(Att) ->
     Att.
 
+to_tuple(#att{name=Name, att_len=Len, type=Type, encoding=Encoding}) ->
 
 Review comment:
   not keen on the name. a record already is a tuple, so I'm guessing the only purpose here is to ignore other fields (and any new fields).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services