You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2015/03/09 04:44:37 UTC

Review Request 31848: RANGER-295: Updated Ranger HDFS plugin for changes in FSPermissionChecker

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31848/
-----------------------------------------------------------

Review request for ranger and Selvamohan Neethiraj.


Bugs: RANGER-295
    https://issues.apache.org/jira/browse/RANGER-295


Repository: ranger


Description
-------

RANGER-295: Updated Ranger HDFS plugin for following changes in FSPermissionChecker:
- class member 'ugi' is now replaced with 'user' and 'groups'
- signature of checkPermissions() method is now changed, as given below:
   New signature: void checkPermission(INodesInPath inodesInPath, boolean doCheckOwner, FsAction ancestorAccess, FsAction parentAccess, FsAction access, FsAction subAccess, boolean ignoreEmptyDir)
   Old signature: void checkPermission(String path, FSDirectory dir, boolean doCheckOwner, FsAction ancestorAccess, FsAction parentAccess, FsAction access, FsAction subAccess, boolean ignoreEmptyDir, boolean resolveLink)

Updated HDFS plugin will work with both new version of FSPermissionChecker and earlier version of FSPermissionChecker.


Diffs
-----

  hdfs-agent/src/main/java/org/apache/hadoop/hdfs/server/namenode/RangerFSPermissionChecker.java 151360f 
  hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/agent/HadoopAuthClassTransformer.java 1f21053 
  hdfs-agent/src/test/java/org/apache/ranger/authorization/hadoop/agent/TestRangerFSPermissionChecker.java 1405bf3 

Diff: https://reviews.apache.org/r/31848/diff/


Testing
-------

Verified that the plugin works with HDFS with updated FSPermissionChecker and its earlier version.


Thanks,

Madhan Neethiraj


Re: Review Request 31848: RANGER-295: Updated Ranger HDFS plugin for changes in FSPermissionChecker

Posted by Selvamohan Neethiraj <sn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31848/#review75657
-----------------------------------------------------------

Ship it!


Ship It!

- Selvamohan Neethiraj


On March 8, 2015, 11:44 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31848/
> -----------------------------------------------------------
> 
> (Updated March 8, 2015, 11:44 p.m.)
> 
> 
> Review request for ranger and Selvamohan Neethiraj.
> 
> 
> Bugs: RANGER-295
>     https://issues.apache.org/jira/browse/RANGER-295
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-295: Updated Ranger HDFS plugin for following changes in FSPermissionChecker:
> - class member 'ugi' is now replaced with 'user' and 'groups'
> - signature of checkPermissions() method is now changed, as given below:
>    New signature: void checkPermission(INodesInPath inodesInPath, boolean doCheckOwner, FsAction ancestorAccess, FsAction parentAccess, FsAction access, FsAction subAccess, boolean ignoreEmptyDir)
>    Old signature: void checkPermission(String path, FSDirectory dir, boolean doCheckOwner, FsAction ancestorAccess, FsAction parentAccess, FsAction access, FsAction subAccess, boolean ignoreEmptyDir, boolean resolveLink)
> 
> Updated HDFS plugin will work with both new version of FSPermissionChecker and earlier version of FSPermissionChecker.
> 
> 
> Diffs
> -----
> 
>   hdfs-agent/src/main/java/org/apache/hadoop/hdfs/server/namenode/RangerFSPermissionChecker.java 151360f 
>   hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/agent/HadoopAuthClassTransformer.java 1f21053 
>   hdfs-agent/src/test/java/org/apache/ranger/authorization/hadoop/agent/TestRangerFSPermissionChecker.java 1405bf3 
> 
> Diff: https://reviews.apache.org/r/31848/diff/
> 
> 
> Testing
> -------
> 
> Verified that the plugin works with HDFS with updated FSPermissionChecker and its earlier version.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>