[GitHub] [systemds] juulez opened a new pull request #1137: builtin arima function

[GitBox <gi...@apache.org>]

juulez opened a new pull request #1137:
URL: https://github.com/apache/systemds/pull/1137


   added a builtin arima function using the (faulty) provided code


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] asfgit closed pull request #1137: builtin arima function

[GitBox <gi...@apache.org>]

asfgit closed pull request #1137:
URL: https://github.com/apache/systemds/pull/1137


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] mboehm7 commented on pull request #1137: builtin arima function

[GitBox <gi...@apache.org>]

mboehm7 commented on pull request #1137:
URL: https://github.com/apache/systemds/pull/1137#issuecomment-753025612


   LGTM - welcome to SystemDS and thanks for the contribution @juulez. This is a very good start for future improvements of this arima script. During the merge, I just made some minor formatting changes and removed some warnings. Regarding tests, I enabled a few configurations that are already passing and will have a look into the other cases soon. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org