You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/05 13:25:22 UTC

[GitHub] [pulsar] hangc0276 commented on a change in pull request #11500: Add metrics for writing or reading size of cursor

hangc0276 commented on a change in pull request #11500:
URL: https://github.com/apache/pulsar/pull/11500#discussion_r683449852



##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursorMXBean.java
##########
@@ -70,4 +70,33 @@
      */
     long getPersistZookeeperErrors();
 
+    /**
+     * Add write data to a ledger of a cursor (in bytes).
+     *
+     * @param size Size of data written to cursor (in bytes)
+     */
+    void addWriteCursorLedgerSize(long size);

Review comment:
       `long size` mark as `final` maybe better.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org