You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "tkalkirill (via GitHub)" <gi...@apache.org> on 2025/06/17 11:50:19 UTC
[PR] IGNITE-25630 Add some data region metrics for aipersist [ignite-3]
tkalkirill opened a new pull request, #6062:
URL: https://github.com/apache/ignite-3/pull/6062
https://issues.apache.org/jira/browse/IGNITE-25630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25630 Add some data region metrics for aipersist [ignite-3]
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill commented on code in PR #6062:
URL: https://github.com/apache/ignite-3/pull/6062#discussion_r2153756075
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java:
##########
@@ -290,6 +291,11 @@ private void initMetrics() {
metricSource.addMetric(new IntGauge(
"MaxCheckpointBufferPages", "The capacity of checkpoint buffer in pages.", this::maxCheckpointBufferPages
));
+ metricSource.addMetric(new LongGauge(
+ "MaxSize",
+ "Maximum region size in bytes.",
Review Comment:
I think there is, for "aipersist" and "aimem" we operate with this.
For example,`org.apache.ignite.internal.pagememory.configuration.schema.PersistentPageMemoryProfileConfigurationSchema#sizeBytes`, indicates the size of the region.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25630 Add some data region metrics for aipersist [ignite-3]
Posted by "sashapolo (via GitHub)" <gi...@apache.org>.
sashapolo commented on code in PR #6062:
URL: https://github.com/apache/ignite-3/pull/6062#discussion_r2153696358
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java:
##########
@@ -290,6 +291,11 @@ private void initMetrics() {
metricSource.addMetric(new IntGauge(
"MaxCheckpointBufferPages", "The capacity of checkpoint buffer in pages.", this::maxCheckpointBufferPages
));
+ metricSource.addMetric(new LongGauge(
+ "MaxSize",
+ "Maximum region size in bytes.",
Review Comment:
Do we still have data regions? I would rephrase it to something like: "Maximum in-memory cache capacity"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25630 Add some data region metrics for aipersist [ignite-3]
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill commented on code in PR #6062:
URL: https://github.com/apache/ignite-3/pull/6062#discussion_r2153819738
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java:
##########
@@ -290,6 +291,11 @@ private void initMetrics() {
metricSource.addMetric(new IntGauge(
"MaxCheckpointBufferPages", "The capacity of checkpoint buffer in pages.", this::maxCheckpointBufferPages
));
+ metricSource.addMetric(new LongGauge(
+ "MaxSize",
+ "Maximum region size in bytes.",
Review Comment:
Fix it a little
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-25630 Add some data region metrics for aipersist [ignite-3]
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill merged PR #6062:
URL: https://github.com/apache/ignite-3/pull/6062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org