You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/12/17 10:12:21 UTC
[GitHub] [skywalking-java] PepoRobert opened a new pull request #85: threadlocal has memory leak risk should be removed after use
PepoRobert opened a new pull request #85:
URL: https://github.com/apache/skywalking-java/pull/85
<!--
โ ๏ธ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== ๐ Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist ๐ ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== ๐ Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist ๐ ==== -->
<!-- ==== ๐ Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist ๐ ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== ๐ Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist ๐ ==== -->
<!-- ==== ๐ Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist ๐ ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking-java/blob/main/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== ๐ Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist ๐ ==== -->
<!-- ==== ๐ Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist ๐ ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== ๐ Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist ๐ ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #85: threadlocal has memory leak risk should be removed after use
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #85:
URL: https://github.com/apache/skywalking-java/pull/85#issuecomment-996671895
OK, we are waiting for the original author to verify. @PepoRobert You need to update the `changes.md` in the update to describe this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #85: threadlocal has memory leak risk should be removed after use
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #85:
URL: https://github.com/apache/skywalking-java/pull/85#discussion_r771355527
##########
File path: changes/changes-8.8.0.md
##########
@@ -40,6 +40,7 @@ Release Notes.
* Add plugin to support okhttp 2.x
* Optimize okhttp 3.x 4.x plugin to get span time cost precisely
* Adapt message header properties of RocketMQ 4.9.x
+* fix the bug httpasyncclient-4.x-plugin has memory leak risk
Review comment:
```suggestion
* Fix httpasyncclient-4.x-plugin's memory leak risk
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng merged pull request #85: Fix httpasyncclient-4.x-plugin's memory leak risk
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #85:
URL: https://github.com/apache/skywalking-java/pull/85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] heihaozi commented on pull request #85: Fix httpasyncclient-4.x-plugin's memory leak risk
Posted by GitBox <gi...@apache.org>.
heihaozi commented on pull request #85:
URL: https://github.com/apache/skywalking-java/pull/85#issuecomment-1001295543
Good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] PepoRobert commented on pull request #85: threadlocal has memory leak risk should be removed after use
Posted by GitBox <gi...@apache.org>.
PepoRobert commented on pull request #85:
URL: https://github.com/apache/skywalking-java/pull/85#issuecomment-996670593
The next interceptor thread has switched remove not take effect
------------------ ๅๅง้ฎไปถ ------------------
ๅไปถไบบ: "apache/skywalking-java" ***@***.***>;
ๅ้ๆถ้ด: 2021ๅนด12ๆ17ๆฅ(ๆๆไบ) ๆไธ7:51
***@***.***>;
***@***.******@***.***>;
ไธป้ข: Re: [apache/skywalking-java] threadlocal has memory leak risk should be removed after use (PR #85)
@heihaozi Could you confirm this? I think this interceptor was introduced by you through #40
โ
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] PepoRobert edited a comment on pull request #85: threadlocal has memory leak risk should be removed after use
Posted by GitBox <gi...@apache.org>.
PepoRobert edited a comment on pull request #85:
URL: https://github.com/apache/skywalking-java/pull/85#issuecomment-996670593
The next interceptor thread has switched, remove not take effect
------------------ ๅๅง้ฎไปถ ------------------
ๅไปถไบบ: "apache/skywalking-java" ***@***.***>;
ๅ้ๆถ้ด: 2021ๅนด12ๆ17ๆฅ(ๆๆไบ) ๆไธ7:51
***@***.***>;
***@***.******@***.***>;
ไธป้ข: Re: [apache/skywalking-java] threadlocal has memory leak risk should be removed after use (PR #85)
@heihaozi Could you confirm this? I think this interceptor was introduced by you through #40
โ
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #85: threadlocal has memory leak risk should be removed after use
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #85:
URL: https://github.com/apache/skywalking-java/pull/85#issuecomment-996605302
It is hard to check as it is contributed from global people. Please provide analysis such as process flow and heap dump to describe the leak.
I am limited to determine this from reading source codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #85: threadlocal has memory leak risk should be removed after use
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #85:
URL: https://github.com/apache/skywalking-java/pull/85#issuecomment-996664122
@heihaozi Could you confirm this? I think this interceptor was introduced by you through https://github.com/apache/skywalking-java/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org