[GitHub] jiangxb1987 commented on a change in pull request #23375: [SPARK-26431][CORE] Update availableSlots by availableCpus for Barrier TaskSet

[GitBox <gi...@apache.org>]

jiangxb1987 commented on a change in pull request #23375: [SPARK-26431][CORE] Update availableSlots by availableCpus for Barrier TaskSet
URL: https://github.com/apache/spark/pull/23375#discussion_r243763633
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
 ##########
 @@ -351,6 +351,11 @@ private[spark] class TaskSchedulerImpl(
    * that tasks are balanced across the cluster.
    */
   def resourceOffers(offers: IndexedSeq[WorkerOffer]): Seq[Seq[TaskDescription]] = synchronized {
+
+    def availableSlots(availableCpus: Array[Int]): Int = {
 
 Review comment:
   The result is not always correct, please refer to `test("don't schedule for a barrier taskSet if available slots are less than pending tasks")`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org