You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Brian Akins <ba...@web.turner.com> on 2005/05/04 22:09:45 UTC
[PATCH] add TCP_DEFER_ACCEPT to 2.0.54
Compiles and works in initial testing on Linux 2.6 (debian sarge).
--
Brian Akins
Lead Systems Engineer
CNN Internet Technologies
Re: [PATCH] add TCP_DEFER_ACCEPT to 2.0.54
Posted by Stas Bekman <st...@stason.org>.
Paul Querna wrote:
> Stas Bekman wrote:
>
>>Brian Akins wrote:
>>
>>
>>>Torsten Foertsch wrote:
>>>
>>>
>>>>Maybe it is worth to make this option settable via httpd.conf?
>>>
>>>
>>>
>>>If there is interest, I could do that.
>>>
>>>This functionality is in 2.1, so some may object to adding this
>>>feature to 2.0. I am investigating its usefulness here, however.
>>
>>
>>Folks, this functionality needs to be removed in 2.1 and 2.0 or somehow
>>made it specific to the http handler. If it stays in it'll break any
>>protocol handler whose protocol starts with a server greeting. So if it
>>stays say bye bye to the SMTP protocol handler, which does exactly that.
>>
>>Torsten has refered to the failing test in the mod_perl test suite which
>>implements an SMTP-like protocol handler. Apparently httpd needs more
>>protocol tests so this kind of "features" won't go in w/o being noticed.
>>
>
> Yes, I know this is broken, thats why I made the listen-protocol branch
> to solve this exact issue.
Cool. Thanks Paul :)
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: [PATCH] add TCP_DEFER_ACCEPT to 2.0.54
Posted by Paul Querna <ch...@force-elite.com>.
Stas Bekman wrote:
> Brian Akins wrote:
>
>> Torsten Foertsch wrote:
>>
>>>
>>> Maybe it is worth to make this option settable via httpd.conf?
>>
>>
>>
>> If there is interest, I could do that.
>>
>> This functionality is in 2.1, so some may object to adding this
>> feature to 2.0. I am investigating its usefulness here, however.
>
>
> Folks, this functionality needs to be removed in 2.1 and 2.0 or somehow
> made it specific to the http handler. If it stays in it'll break any
> protocol handler whose protocol starts with a server greeting. So if it
> stays say bye bye to the SMTP protocol handler, which does exactly that.
>
> Torsten has refered to the failing test in the mod_perl test suite which
> implements an SMTP-like protocol handler. Apparently httpd needs more
> protocol tests so this kind of "features" won't go in w/o being noticed.
>
Yes, I know this is broken, thats why I made the listen-protocol branch
to solve this exact issue.
-Paul
Re: [PATCH] add TCP_DEFER_ACCEPT to 2.0.54
Posted by Stas Bekman <st...@stason.org>.
Brian Akins wrote:
> Torsten Foertsch wrote:
>
>>
>> Maybe it is worth to make this option settable via httpd.conf?
>
>
> If there is interest, I could do that.
>
> This functionality is in 2.1, so some may object to adding this feature
> to 2.0. I am investigating its usefulness here, however.
Folks, this functionality needs to be removed in 2.1 and 2.0 or somehow
made it specific to the http handler. If it stays in it'll break any
protocol handler whose protocol starts with a server greeting. So if it
stays say bye bye to the SMTP protocol handler, which does exactly that.
Torsten has refered to the failing test in the mod_perl test suite which
implements an SMTP-like protocol handler. Apparently httpd needs more
protocol tests so this kind of "features" won't go in w/o being noticed.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: [PATCH] add TCP_DEFER_ACCEPT to 2.0.54
Posted by Brian Akins <ba...@web.turner.com>.
Torsten Foertsch wrote:
>
> Maybe it is worth to make this option settable via httpd.conf?
If there is interest, I could do that.
This functionality is in 2.1, so some may object to adding this feature
to 2.0. I am investigating its usefulness here, however.
--
Brian Akins
Lead Systems Engineer
CNN Internet Technologies
Re: [PATCH] add TCP_DEFER_ACCEPT to 2.0.54
Posted by Torsten Foertsch <to...@gmx.net>.
On Wednesday 04 May 2005 22:09, Brian Akins wrote:
> Compiles and works in initial testing on Linux 2.6 (debian sarge).
I have tried that out and found that everything is working except testing
mod_perl. The reason is simple and to be expected. One test
(t/protocol/pseudo_http) implements a protocol module and is expecting to get
something (the string HELO) from the server before sending any data.
Maybe it is worth to make this option settable via httpd.conf?
Torsten