You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2024/09/24 08:28:49 UTC
[PR] Change default .airflowignore syntax to glob [airflow]
uranusjr opened a new pull request, #42436:
URL: https://github.com/apache/airflow/pull/42436
This matches the ignore file behavior of many popular tools (e.g. Git, Docker) and is likely what most users expect without reading the documentation.
The documentation is also tweaked to emphasize the new default. I also decided to get rid of some regexp examples entirely; I figure most of the users are better off either using glob, or just customize the might_contain_dag_callable hook instead. The regexp syntax parser uses re2, which is quite limiting for security reasons, and does not offer significant advantages over glob for almost all use cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change default .airflowignore syntax to glob [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #42436:
URL: https://github.com/apache/airflow/pull/42436#discussion_r1778228577
##########
docs/apache-airflow/core-concepts/dags.rst:
##########
@@ -712,19 +712,10 @@ configuration parameter (*added in Airflow 2.3*): ``regexp`` and ``glob``.
.. note::
- The default ``DAG_IGNORE_FILE_SYNTAX`` is ``regexp`` to ensure backwards compatibility.
+ The default ``DAG_IGNORE_FILE_SYNTAX`` is ``glob`` in Airflow 3 or later.
+ The default was ``regexp`` in previous Airflow versions.
Review Comment:
```suggestion
The default ``DAG_IGNORE_FILE_SYNTAX`` is ``glob`` in Airflow 3 or later (in previous versions it was ``regexp``).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org