[jira] [Comment Edited] (VFS-422) Allows to create other channels in SftpFileSystem

["Benjamin Piwowarski (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/VFS-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398506#comment-13398506 ] 

Benjamin Piwowarski edited comment on VFS-422 at 6/21/12 3:49 PM:
------------------------------------------------------------------

Here are answers to your question

On formats:
* I will use the standard diff format - hopeful the test will pass (I have no trouble on my side after a clean)
* I now use the block style
* I added some comments on Jsch

Other things
* The session type is now an enum (I just copied the JSch way in the first patch)
* The runtime exception was just a way to see if the code was executed at some point (removed)
* Keeping track of how many objects are instantiated is important if we want to answer correctly to the "isReleasable" question - otherwise, opened channel will be closed when disposing of the filesystem, unless I misunderstood how VFS was working.

I will post an updated patch soon.

PS. my time zone is CEST.
                
      was (Author: bpiwowar):
    Here are answers to your question

On formats:
* I will use the standard diff format - hopeful the test will pass (I have no trouble on my side after a clean)
* I now use the block style
* I added some comments on Jsch

Other things
* The runtime exception was just a way to see if the code was executed at some point (removed)
* Keeping track of how many objects are instantiated is important if we want to answer correctly to the "isReleasable" question - otherwise, opened channel will be closed when disposing of the filesystem, unless I misunderstood how VFS was working.

I will post an updated patch soon.

PS. my time zone is CEST.
                  
> Allows to create other channels in SftpFileSystem
> -------------------------------------------------
>
>                 Key: VFS-422
>                 URL: https://issues.apache.org/jira/browse/VFS-422
>             Project: Commons VFS
>          Issue Type: Improvement
>    Affects Versions: 2.0
>         Environment: Any
>            Reporter: Benjamin Piwowarski
>         Attachments: 0001-SftpFileSystems-allows-opening-external-channels.patch
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> In the software I am writing, I need to execute commands when the filesystems "allows" it, i.e. local or via ssh (i.e. sftp filesystem). 
> For a local filesystem, I can easily do this, but for Sftp, there is no way to get a channel different than the SFTP on, so it would be great if other channels could be open.
> I could submit a patch that would:
> 1) Allows a call to session.openChannel(String type) [following getChannel()]
> 2) Overwrite isReleaseable to keep the filesystem open if some external channels are open

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira