You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/09/24 07:25:32 UTC

[GitHub] [incubator-mxnet] mseth10 commented on pull request #19214: [BUGFIX] Free up executor memory when reassigning new executor

mseth10 commented on pull request #19214:
URL: https://github.com/apache/incubator-mxnet/pull/19214#issuecomment-698167258


   Looks like we only instantiate the object the first time because we want to check whether subgraph property is set, which has nothing to do with the executor really. We can define a variable like this and use it in the condition: https://github.com/apache/incubator-mxnet/blob/07e65e5cf3c629c78f206798f33a3529e95c0fc4/src/executor/graph_executor.cc#L58
   This will simplify the code and then we only need to instantiate object once after the if block. WDYT? @access2rohit 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org