You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2017/09/21 10:24:36 UTC
[GitHub] spark pull request #19305: [SPARK-22088][SQL] Incorrect scalastyle comment c...
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/19305
[SPARK-22088][SQL] Incorrect scalastyle comment causes wrong styles in stringExpressions
## What changes were proposed in this pull request?
There is an incorrect `scalastyle:on` comment in `stringExpressions.scala` and causes the line size limit check ineffective in the file. There are many lines of code which are more than 100 chars.
## How was this patch tested?
Code style change only.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viirya/spark-1 fix-wrong-style
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19305.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19305
----
commit 21140184af0d67c65b50958fd9113ab77f3e8707
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2017-09-21T10:19:34Z
Fix wrong style.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19305: [SPARK-22088][SQL] Incorrect scalastyle comment causes w...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19305
**[Test build #82035 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82035/testReport)** for PR 19305 at commit [`79b135a`](https://github.com/apache/spark/commit/79b135ab3c466227ca68cf0dd5ccc7be69fd3369).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19305: [SPARK-22088][SQL] Incorrect scalastyle comment causes w...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19305
**[Test build #82029 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82029/testReport)** for PR 19305 at commit [`2114018`](https://github.com/apache/spark/commit/21140184af0d67c65b50958fd9113ab77f3e8707).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19305: [SPARK-22088][SQL] Incorrect scalastyle comment causes w...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19305
Thanks! Merged to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19305: [SPARK-22088][SQL] Incorrect scalastyle comment c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19305
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19305: [SPARK-22088][SQL] Incorrect scalastyle comment causes w...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19305
cc @gatorsmile @HyukjinKwon
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19305: [SPARK-22088][SQL] Incorrect scalastyle comment causes w...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19305
LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19305: [SPARK-22088][SQL] Incorrect scalastyle comment causes w...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19305
**[Test build #82035 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82035/testReport)** for PR 19305 at commit [`79b135a`](https://github.com/apache/spark/commit/79b135ab3c466227ca68cf0dd5ccc7be69fd3369).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19305: [SPARK-22088][SQL] Incorrect scalastyle comment causes w...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19305
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19305: [SPARK-22088][SQL] Incorrect scalastyle comment causes w...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19305
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82035/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19305: [SPARK-22088][SQL] Incorrect scalastyle comment c...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19305#discussion_r140206602
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala ---
@@ -644,6 +652,7 @@ object StringTrimLeft {
> SELECT _FUNC_('Sp', 'SSparkSQLS');
arkSQLS
""")
+// scalastyle:on line.size.limit
--- End diff --
Looks we are okay here with disabling.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19305: [SPARK-22088][SQL] Incorrect scalastyle comment c...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19305#discussion_r140239970
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala ---
@@ -644,6 +652,7 @@ object StringTrimLeft {
> SELECT _FUNC_('Sp', 'SSparkSQLS');
arkSQLS
""")
+// scalastyle:on line.size.limit
--- End diff --
Yeah, I see. Just put it in case. Since you said, I will remove it. :)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19305: [SPARK-22088][SQL] Incorrect scalastyle comment c...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19305#discussion_r140206696
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala ---
@@ -548,6 +551,7 @@ object StringTrim {
> SELECT _FUNC_(BOTH 'SL' FROM 'SSparkSQLS');
parkSQ
""")
+// scalastyle:on line.size.limit
--- End diff --
Here too, it looks we are fine okay without disabling it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org