You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/21 06:48:40 UTC
[GitHub] [incubator-superset] chuancyzhang opened a new issue #10373: Pivot Table can't display Null value when some column is null
chuancyzhang opened a new issue #10373:
URL: https://github.com/apache/incubator-superset/issues/10373
when some datasource column is null, Pivot Table can't display Null value.
### Expected results
### Actual results
#### Screenshots
If applicable, add screenshots to help explain your problem.
#### How to reproduce the bug
1. Go to Chart
2. Click on Pivot Table
3. Scroll down to some Null Value in datasource
4. See error
### Environment
(please complete the following information):
- superset version: 0.36.0
- python version: 3.6.6
- node.js version: `node -v`
- npm version: `npm -v`
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [ ] I have reproduced the issue with at least the latest released version of superset.
- [ ] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Finally, I find the bug that is DataFrame in PivotTableViz Class not fill Null. pandas will throw away nulls when grouping/pivoting,
so i substitute NULL_STRING for any nulls in the necessary columns.
```
df = df.fillna(value=NULL_STRING).pivot_table(
index=groupby,
columns=columns,
values=metrics,
aggfunc=aggfunc,
margins=self.form_data.get("pivot_margins"),
)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] chuancyzhang commented on issue #10373: Pivot Table can't display Null value when some column is null
Posted by GitBox <gi...@apache.org>.
chuancyzhang commented on issue #10373:
URL: https://github.com/apache/incubator-superset/issues/10373#issuecomment-661736864
> Thanks for opening this ticket @chuancyzhang ! Your proposed solution looks valid; would you be interested in opening a Pull Request for this?
please refer PR [#10371](https://github.com/apache/incubator-superset/pull/10376)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #10373: Pivot Table can't display Null value when some column is null
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #10373:
URL: https://github.com/apache/incubator-superset/issues/10373#issuecomment-661675325
Thanks for opening this ticket @chuancyzhang ! Your proposed solution looks valid; would you be interested in opening a Pull Request for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #10373: Pivot Table can't display Null value when some column is null
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #10373:
URL: https://github.com/apache/incubator-superset/issues/10373#issuecomment-695712465
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] chuancyzhang edited a comment on issue #10373: Pivot Table can't display Null value when some column is null
Posted by GitBox <gi...@apache.org>.
chuancyzhang edited a comment on issue #10373:
URL: https://github.com/apache/incubator-superset/issues/10373#issuecomment-661736864
> Thanks for opening this ticket @chuancyzhang ! Your proposed solution looks valid; would you be interested in opening a Pull Request for this?
please refer PR [#10371](https://github.com/apache/incubator-superset/pull/10377)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] GiannisDimitriou commented on issue #10373: Pivot Table can't display Null value when some column is null
Posted by GitBox <gi...@apache.org>.
GiannisDimitriou commented on issue #10373:
URL: https://github.com/apache/incubator-superset/issues/10373#issuecomment-726810596
@villebro is this issue fixed?
I am experiencing a similar issue, when the `Group By` column has null value it is not displayed at all.
I can open a new ticket if this is a different issue after all
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] chuancyzhang edited a comment on issue #10373: Pivot Table can't display Null value when some column is null
Posted by GitBox <gi...@apache.org>.
chuancyzhang edited a comment on issue #10373:
URL: https://github.com/apache/incubator-superset/issues/10373#issuecomment-661736864
> Thanks for opening this ticket @chuancyzhang ! Your proposed solution looks valid; would you be interested in opening a Pull Request for this?
please refer PR [#10377](https://github.com/apache/incubator-superset/pull/10377)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #10373: Pivot Table can't display Null value when some column is null
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #10373:
URL: https://github.com/apache/incubator-superset/issues/10373#issuecomment-727783634
@GiannisDimitriou please open a new ticket if this problem persists in master branch or the latest released version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #10373: Pivot Table can't display Null value when some column is null
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #10373:
URL: https://github.com/apache/incubator-superset/issues/10373#issuecomment-661669503
Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.92. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] closed issue #10373: Pivot Table can't display Null value when some column is null
Posted by GitBox <gi...@apache.org>.
stale[bot] closed issue #10373:
URL: https://github.com/apache/incubator-superset/issues/10373
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org