You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by Xaprice <gi...@git.apache.org> on 2017/11/22 01:51:02 UTC
[GitHub] carbondata pull request #1547: [CARBONDATA-1792]add example of data manageme...
GitHub user Xaprice opened a pull request:
https://github.com/apache/carbondata/pull/1547
[CARBONDATA-1792]add example of data management for Spark2.X
[CARBONDATA-1792]add example of data management for Spark2.X
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Xaprice/carbondata master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1547.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1547
----
commit 8511ffa1572d15c4dc7141c8833bdee799cbf15f
Author: Jin Zhou <xa...@yeah.net>
Date: 2017-11-21T14:57:58Z
add example for data management
----
---
[GitHub] carbondata issue #1547: [CARBONDATA-1792] Add example of data management for...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1547
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1831/
---
[GitHub] carbondata pull request #1547: [CARBONDATA-1792]add example of data manageme...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1547#discussion_r152595009
--- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/DataManagementExample.scala ---
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.examples
+
+import java.io.File
+
+object DataManagementExample {
+
+ def main(args: Array[String]) {
+ val spark = ExampleUtils.createCarbonSession("DataManagementExample")
+ spark.sparkContext.setLogLevel("WARN")
+
+ spark.sql("DROP TABLE IF EXISTS carbon_table")
+
+ // Create table
+ spark.sql(
+ s"""
+ | CREATE TABLE IF NOT EXISTS carbon_table(
+ | ID Int,
+ | date Date,
+ | country String,
+ | name String,
+ | phonetype String,
+ | serialname String,
+ | salary Int,
+ | floatField float
+ | ) STORED BY 'carbondata'
+ """.stripMargin)
+
+ // data.csv has 10 lines
--- End diff --
this row comment is not required :
// data.csv has 10 lines
---
[GitHub] carbondata issue #1547: [CARBONDATA-1792] Add example of data management for...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1547
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1383/
---
[GitHub] carbondata issue #1547: [CARBONDATA-1792]add example of data management for ...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1547
add to whitelist
---
[GitHub] carbondata issue #1547: [CARBONDATA-1792] Add example of data management for...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1547
LGTM
---
[GitHub] carbondata issue #1547: [CARBONDATA-1792]add example of data management for ...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1547
Please follow the below template to provide pull request description.
--------------------------------------------------------------------
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
---
[GitHub] carbondata pull request #1547: [CARBONDATA-1792] Add example of data managem...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1547
---
[GitHub] carbondata issue #1547: [CARBONDATA-1792]add example of data management for ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1547
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1362/
---
[GitHub] carbondata issue #1547: [CARBONDATA-1792]add example of data management for ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1547
Can one of the admins verify this patch?
---
[GitHub] carbondata issue #1547: [CARBONDATA-1792]add example of data management for ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1547
Can one of the admins verify this patch?
---
[GitHub] carbondata issue #1547: [CARBONDATA-1792]add example of data management for ...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1547
retest this please
---
[GitHub] carbondata issue #1547: [CARBONDATA-1792]add example of data management for ...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1547
the pr title please change to : [CARBONDATA-1792] Add example of data management for Spark2.X
---
[GitHub] carbondata issue #1547: [CARBONDATA-1792]add example of data management for ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1547
Can one of the admins verify this patch?
---