You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ji...@apache.org on 2016/12/13 01:09:57 UTC
[4/5] mesos git commit: Fixed the tests by turning off agent
subsystems in IOSwitchboard tests.
Fixed the tests by turning off agent subsystems in IOSwitchboard tests.
Agent subsystems should be not be used if the corresponding cgroups
isolator is not used. Ideally, we should add a check in Mesos to
disallow such a combination.
Review: https://reviews.apache.org/r/54682
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/354bca13
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/354bca13
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/354bca13
Branch: refs/heads/master
Commit: 354bca1311c5b3b98a2a50689f0fba6a033e743d
Parents: 1d73345
Author: Jie Yu <yu...@gmail.com>
Authored: Mon Dec 12 15:40:20 2016 -0800
Committer: Jie Yu <yu...@gmail.com>
Committed: Mon Dec 12 16:23:09 2016 -0800
----------------------------------------------------------------------
src/tests/containerizer/io_switchboard_tests.cpp | 4 ++++
1 file changed, 4 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/354bca13/src/tests/containerizer/io_switchboard_tests.cpp
----------------------------------------------------------------------
diff --git a/src/tests/containerizer/io_switchboard_tests.cpp b/src/tests/containerizer/io_switchboard_tests.cpp
index a1ac755..5b7a668 100644
--- a/src/tests/containerizer/io_switchboard_tests.cpp
+++ b/src/tests/containerizer/io_switchboard_tests.cpp
@@ -468,6 +468,7 @@ TEST_F(IOSwitchboardTest, ContainerAttach)
slave::Flags flags = CreateSlaveFlags();
flags.launcher = "posix";
flags.isolation = "posix/cpu";
+ flags.agent_subsystems = None();
Fetcher fetcher;
@@ -534,6 +535,7 @@ TEST_F(IOSwitchboardTest, OutputRedirectionWithTTY)
slave::Flags flags = CreateSlaveFlags();
flags.launcher = "posix";
flags.isolation = "posix/cpu";
+ flags.agent_subsystems = None();
Fetcher fetcher;
@@ -599,6 +601,7 @@ TEST_F(IOSwitchboardTest, KillSwitchboardContainerDestroyed)
slave::Flags flags = CreateSlaveFlags();
flags.launcher = "posix";
flags.isolation = "posix/cpu";
+ flags.agent_subsystems = None();
Fetcher fetcher;
@@ -673,6 +676,7 @@ TEST_F(IOSwitchboardTest, RecoverThenKillSwitchboardContainerDestroyed)
slave::Flags flags = CreateSlaveFlags();
flags.launcher = "posix";
flags.isolation = "posix/cpu";
+ flags.agent_subsystems = None();
Fetcher fetcher;