You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Aleksandar Vidakovic (Jira)" <ji...@apache.org> on 2022/02/06 01:34:00 UTC

[jira] [Commented] (FINERACT-764) Run Integration Tests using Spring Boot IT support instead of on Tomcat started separately by gradle-tomcat-plugin

    [ https://issues.apache.org/jira/browse/FINERACT-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487604#comment-17487604 ] 

Aleksandar Vidakovic commented on FINERACT-764:
-----------------------------------------------

FINERACT-1467 is almost working. I'm holding it back, because the whole test suite runs currently with Github Actions > 2h using Testcontainers. This is 30-40% longer than the current Tomcat plugin approach. I'm moving this one to version 1.7.0. Key to make these test faster will be parallel execution.

> Run Integration Tests using Spring Boot IT support instead of on Tomcat started separately by gradle-tomcat-plugin
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: FINERACT-764
>                 URL: https://issues.apache.org/jira/browse/FINERACT-764
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Michael Vorburger
>            Assignee: Aleksandar Vidakovic
>            Priority: Major
>             Fix For: 1.6.0
>
>
> https://github.com/apache/fineract/pull/525 for FINERACT-700 struggles to get "./gradlew integrationTest" working under an up-to-date Gradle version, due to the gradle-tomcat-plugin failing to start Tomcat. The problem can also be seen (on that PR, as it stands right now) via {{./gradlew tomcatrunwar}}.
> https://github.com/bmuschko/gradle-tomcat-plugin mentions that its author "I don't have much time to contribute anymore. In practice this means far less activity, responsiveness on issues and new releases from my end."
> What we IMHO really should do instead is to ditch our use of gradle-tomcat-plugin and just use Spring Boot's very nice built-in support for Integration Test, see here:
> * https://docs.spring.io/spring-boot/docs/2.1.5.RELEASE/reference/htmlsingle/#boot-features-testing-spring-applications
> * https://www.baeldung.com/spring-boot-testing (see 7. Integration Testing with @SpringBootTest)
> * https://reflectoring.io/spring-boot-test/
> I wouldn't have time for this, but perhaps someone would like to pick this up?



--
This message was sent by Atlassian Jira
(v8.20.1#820001)