You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/06/13 07:54:16 UTC

Review Request 35413: DRILL-3285: Part 1--Prep., Hygiene: Mainly, adding comments.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35413/
-----------------------------------------------------------

Review request for drill, Mehant Baid and Parth Chandra.


Bugs: DRILL-3285
    https://issues.apache.org/jira/browse/DRILL-3285


Repository: drill-git


Description
-------

Added/edited comments:
- field doc. comments
- method doc. comments
- branch/block comments

Removed unused recordBatchCount and getRecordBatchCount().

Added logger call for spurious batch.

Various cleanup:
- Cleaned up logger.
- Added "final" on updateColumns().
- Wrapped some lines
- Misc. comment whitespace.


Diffs
-----

  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java PRE-CREATION 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java cb6bd1d 

Diff: https://reviews.apache.org/r/35413/diff/


Testing
-------

Ran tests (all parts together); no new errors.


Thanks,

Daniel Barclay