You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "svetakvsundhar (via GitHub)" <gi...@apache.org> on 2023/09/15 18:22:27 UTC
[GitHub] [beam] svetakvsundhar opened a new pull request, #28482: [Document]: `HealthcareApiClient` methods.
svetakvsundhar opened a new pull request, #28482:
URL: https://github.com/apache/beam/pull/28482
Fixes https://github.com/apache/beam/issues/28415.
Several methods are undocumented in the `HealthcareApiClient`. We should document these parameters for better user experience, given that the user will not have access to the client libraries being used under the hood.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn merged pull request #28482: [Document]: `HealthcareApiClient` methods.
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #28482:
URL: https://github.com/apache/beam/pull/28482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28482: [Document]: `HealthcareApiClient` methods.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28482:
URL: https://github.com/apache/beam/pull/28482#issuecomment-1721679931
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #28482: [Document]: `HealthcareApiClient` methods.
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #28482:
URL: https://github.com/apache/beam/pull/28482#issuecomment-1721718934
Spotless error: `Error: eckstyle] [ERROR] /runner/_work/beam/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HealthcareApiClient.java:194:6: Unused @param tag for 'fhirStore'. [JavadocMethod]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] svetakvsundhar commented on pull request #28482: [Document]: `HealthcareApiClient` methods.
Posted by "svetakvsundhar (via GitHub)" <gi...@apache.org>.
svetakvsundhar commented on PR #28482:
URL: https://github.com/apache/beam/pull/28482#issuecomment-1721677822
R: @Abacn for committer review
R: [@rachelgagnon](https://github.com/rachelgagnon) for domain review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28482: [Document]: `HealthcareApiClient` methods.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28482:
URL: https://github.com/apache/beam/pull/28482#issuecomment-1721715431
## Test Results
6 files - 1 6 suites - 1 54m 7s [:stopwatch:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v2.9.0/README.md#the-symbols "duration of all tests") + 49m 56s
4 tests - 38 4 [:heavy_check_mark:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v2.9.0/README.md#the-symbols "passed tests") - 38 0 [:zzz:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v2.9.0/README.md#the-symbols "skipped / disabled tests") ±0 0 [:x:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v2.9.0/README.md#the-symbols "failed tests") ±0
10 runs - 32 10 [:heavy_check_mark:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v2.9.0/README.md#the-symbols "passed tests") - 32 0 [:zzz:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v2.9.0/README.md#the-symbols "skipped / disabled tests") ±0 0 [:x:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v2.9.0/README.md#the-symbols "failed tests") ±0
Results for commit 458d3808. ± Comparison against base commit ec422dbf.
<details>
<summary>This pull request <b>removes</b> 42 and <b>adds</b> 4 tests. <i>Note that renamed tests count towards both.</i></summary>
```
org.apache.beam.sdk.io.hbase.HBaseCoderProviderRegistrarTest ‑ testMutationCoderIsRegistered
org.apache.beam.sdk.io.hbase.HBaseCoderProviderRegistrarTest ‑ testResultCoderIsRegistered
org.apache.beam.sdk.io.hbase.HBaseCoderProviderRegistrarTest ‑ testRowMutationsCoderIsRegistered
org.apache.beam.sdk.io.hbase.HBaseIOTest ‑ testReadBuildsCorrectly
org.apache.beam.sdk.io.hbase.HBaseIOTest ‑ testReadBuildsCorrectlyInDifferentOrder
org.apache.beam.sdk.io.hbase.HBaseIOTest ‑ testReading
org.apache.beam.sdk.io.hbase.HBaseIOTest ‑ testReadingDisplayData
org.apache.beam.sdk.io.hbase.HBaseIOTest ‑ testReadingEmptyTable
org.apache.beam.sdk.io.hbase.HBaseIOTest ‑ testReadingFailsTableDoesNotExist
org.apache.beam.sdk.io.hbase.HBaseIOTest ‑ testReadingKeyRangeMiddle
…
```
```
org.apache.beam.examples.WindowedWordCountIT ‑ testWindowedWordCountInBatchDynamicSharding
org.apache.beam.examples.WindowedWordCountIT ‑ testWindowedWordCountInBatchStaticSharding
org.apache.beam.examples.WindowedWordCountIT ‑ testWindowedWordCountInStreamingStaticSharding
org.apache.beam.examples.WordCountIT ‑ testE2EWordCount
```
</details>
[test-results]:data:application/gzip;base64,H4sIAMepBGUC/1WMyw7CIBBFf6Vh7QKE4sSfMVMeycS2GB4r479LG6l0d8+5yXkzT7NL7D7oy8BSoXyALREzhbWivKpbNfXL26vafqRizFk86VUFP4RHmk/CxRjiz8Sybj3Rdut14t/bucvt3NdMWBbKFZgawUrgAG4UgjtlnZk851Kh1KBAC8RJo0T2+QKgR3oqAAEAAA==
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] svetakvsundhar commented on pull request #28482: [Document]: `HealthcareApiClient` methods.
Posted by "svetakvsundhar (via GitHub)" <gi...@apache.org>.
svetakvsundhar commented on PR #28482:
URL: https://github.com/apache/beam/pull/28482#issuecomment-1721720756
> Spotless error: `Error: eckstyle] [ERROR] /runner/_work/beam/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HealthcareApiClient.java:194:6: Unused @param tag for 'fhirStore'. [JavadocMethod]`
whoops. should be fixed in new commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] svetakvsundhar commented on pull request #28482: [Document]: `HealthcareApiClient` methods.
Posted by "svetakvsundhar (via GitHub)" <gi...@apache.org>.
svetakvsundhar commented on PR #28482:
URL: https://github.com/apache/beam/pull/28482#issuecomment-1722300690
Run Java_GCP_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org