You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/10/20 05:53:30 UTC
[GitHub] [hive] pudidic commented on a diff in pull request #3644: HIVE-26437: Dump unpartitioned tables in parallel.
pudidic commented on code in PR #3644:
URL: https://github.com/apache/hive/pull/3644#discussion_r1000168804
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java:
##########
@@ -1254,6 +1273,7 @@ Long bootStrapDump(Path dumpRoot, DumpMetaData dmd, Path cmRoot, Hive hiveDb)
// Get the counter to store the snapshots created & deleted at source.
replSnapshotCount = new SnapshotUtils.ReplSnapshotCount();
}
+ ExportService exportService = new ExportService(conf);
Review Comment:
Please move the ExportService object creation higher than a database level.
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java:
##########
@@ -1290,6 +1310,21 @@ Long bootStrapDump(Path dumpRoot, DumpMetaData dmd, Path cmRoot, Hive hiveDb)
}
}
+ if (exportService != null && exportService.isExportServiceRunning()) {
Review Comment:
Please move the ExportService object creation higher than a database level.
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java:
##########
@@ -952,6 +954,7 @@ private Long incrementalDump(Path dumpRoot, DumpMetaData dmd, Path cmRoot, Hive
}
}
for(String matchedDbName : Utils.matchesDb(hiveDb, work.dbNameOrPattern)) {
+ ExportService exportService = new ExportService(conf);
Review Comment:
Please move the ExportService object creation higher than a database level.
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java:
##########
@@ -978,6 +981,22 @@ private Long incrementalDump(Path dumpRoot, DumpMetaData dmd, Path cmRoot, Hive
LOG.debug(te.getMessage());
}
}
+
+ if (exportService != null && exportService.isExportServiceRunning()) {
Review Comment:
Please move the ExportService object creation higher than a database level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org