You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/07/12 08:49:24 UTC

[GitHub] [zeppelin] zjffdu opened a new pull request #4173: [ZEPPELIN-5455] Spark conf can not contain white space

zjffdu opened a new pull request #4173:
URL: https://github.com/apache/zeppelin/pull/4173


   ### What is this PR for?
   
   This PR would use `|` as parameter delimiter, although it can not resolve the issue fundamentally, because parameter may still contain `|`, but it would mitigate the issue a lot. 
   
   ### What type of PR is it?
   [Improvement ]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5455
   
   ### How should this be tested?
   * Manually tested
   
   ### Screenshots (if appropriate)
   ![image](https://user-images.githubusercontent.com/164491/125258545-09aa7200-e331-11eb-8a56-5c68417ae7bc.png)
   
   
   ### Questions:
   * Does the licenses files need update? NO
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu closed pull request #4173: [ZEPPELIN-5455] Spark conf can not contain white space

Posted by GitBox <gi...@apache.org>.
zjffdu closed pull request #4173:
URL: https://github.com/apache/zeppelin/pull/4173


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #4173: [ZEPPELIN-5455] Spark conf can not contain white space

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4173:
URL: https://github.com/apache/zeppelin/pull/4173#issuecomment-878124118


   @zjffdu 
   Please take a look at #4127 and my [comment](https://github.com/apache/zeppelin/pull/4127#issuecomment-864825992). I tried to remove IFS, which is not correct for word splitting.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #4173: [ZEPPELIN-5455] Spark conf can not contain white space

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4173:
URL: https://github.com/apache/zeppelin/pull/4173#issuecomment-892316973


   Will merge if no more comment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on a change in pull request #4173: [ZEPPELIN-5455] Spark conf can not contain white space

Posted by GitBox <gi...@apache.org>.
Reamer commented on a change in pull request #4173:
URL: https://github.com/apache/zeppelin/pull/4173#discussion_r681461670



##########
File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/launcher/SparkInterpreterLauncher.java
##########
@@ -106,7 +106,7 @@ public SparkInterpreterLauncher(ZeppelinConfiguration zConf, RecoveryStorage rec
               " to false if you want to use other modes.");
     }
 
-    StringBuilder sparkConfBuilder = new StringBuilder();
+    List<String> sparkConfList = new ArrayList<>();

Review comment:
       A StringJoiner is more elegant
   
   https://docs.oracle.com/javase/8/docs/api/java/util/StringJoiner.html




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #4173: [ZEPPELIN-5455] Spark conf can not contain white space

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4173:
URL: https://github.com/apache/zeppelin/pull/4173


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4173: [ZEPPELIN-5455] Spark conf can not contain white space

Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #4173:
URL: https://github.com/apache/zeppelin/pull/4173#discussion_r681474007



##########
File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/launcher/SparkInterpreterLauncher.java
##########
@@ -106,7 +106,7 @@ public SparkInterpreterLauncher(ZeppelinConfiguration zConf, RecoveryStorage rec
               " to false if you want to use other modes.");
     }
 
-    StringBuilder sparkConfBuilder = new StringBuilder();
+    List<String> sparkConfList = new ArrayList<>();

Review comment:
       Thanks for the review, PR is updated, `SparkInterpreterLauncher` & `FlinkInterpreterLauncher` both use StringJoiner now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #4173: [ZEPPELIN-5455] Spark conf can not contain white space

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4173:
URL: https://github.com/apache/zeppelin/pull/4173


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org