You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2014/01/27 16:24:53 UTC
Review Request 17393: Add upgradestack support for MySQL
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17393/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
Bugs: AMBARI-4425
https://issues.apache.org/jira/browse/AMBARI-4425
Repository: ambari
Description
-------
Similar to Oracle/Postgres we need to make sure that ambari-server upgradestack works for MySQL
Diffs
-----
ambari-server/src/main/python/ambari-server.py 2ace986
ambari-server/src/main/resources/upgrade/dml/Ambari-DML-MySQL-UPGRADE_STACK.sql PRE-CREATION
Diff: https://reviews.apache.org/r/17393/diff/
Testing
-------
Thanks,
Vitalyi Brodetskyi
Re: Review Request 17393: Add upgradestack support for MySQL
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17393/#review32869
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Jan. 27, 2014, 6:56 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17393/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 6:56 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
>
>
> Bugs: AMBARI-4425
> https://issues.apache.org/jira/browse/AMBARI-4425
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Similar to Oracle/Postgres we need to make sure that ambari-server upgradestack works for MySQL
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py 2ace986
> ambari-server/src/main/resources/upgrade/dml/Ambari-DML-MySQL-UPGRADE_STACK.sql PRE-CREATION
> ambari-server/src/test/python/TestAmbariServer.py 0e90d7b
>
> Diff: https://reviews.apache.org/r/17393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 17393: Add upgradestack support for MySQL
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17393/#review32860
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 27, 2014, 6:56 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17393/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 6:56 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
>
>
> Bugs: AMBARI-4425
> https://issues.apache.org/jira/browse/AMBARI-4425
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Similar to Oracle/Postgres we need to make sure that ambari-server upgradestack works for MySQL
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py 2ace986
> ambari-server/src/main/resources/upgrade/dml/Ambari-DML-MySQL-UPGRADE_STACK.sql PRE-CREATION
> ambari-server/src/test/python/TestAmbariServer.py 0e90d7b
>
> Diff: https://reviews.apache.org/r/17393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 17393: Add upgradestack support for MySQL
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17393/
-----------------------------------------------------------
(Updated Jan. 27, 2014, 6:56 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
Changes
-------
Patch Updated. Please take a look at it.
Bugs: AMBARI-4425
https://issues.apache.org/jira/browse/AMBARI-4425
Repository: ambari
Description
-------
Similar to Oracle/Postgres we need to make sure that ambari-server upgradestack works for MySQL
Diffs (updated)
-----
ambari-server/src/main/python/ambari-server.py 2ace986
ambari-server/src/main/resources/upgrade/dml/Ambari-DML-MySQL-UPGRADE_STACK.sql PRE-CREATION
ambari-server/src/test/python/TestAmbariServer.py 0e90d7b
Diff: https://reviews.apache.org/r/17393/diff/
Testing
-------
Thanks,
Vitalyi Brodetskyi
Re: Review Request 17393: Add upgradestack support for MySQL
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17393/#review32841
-----------------------------------------------------------
LGTM except missing unit tests
- Dmitro Lisnichenko
On Jan. 27, 2014, 3:24 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17393/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 3:24 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
>
>
> Bugs: AMBARI-4425
> https://issues.apache.org/jira/browse/AMBARI-4425
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Similar to Oracle/Postgres we need to make sure that ambari-server upgradestack works for MySQL
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py 2ace986
> ambari-server/src/main/resources/upgrade/dml/Ambari-DML-MySQL-UPGRADE_STACK.sql PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 17393: Add upgradestack support for MySQL
Posted by Sumit Mohanty <sm...@hortonworks.com>.
> On Jan. 27, 2014, 4:54 p.m., Sumit Mohanty wrote:
> > Can we add a unit test that verifies that upgradestack is called when "ambari-server upgrade" is called?
> >
> > This is not critical for this specific JIRA but if upgradestack encounters an error then will it be logged to console when we call "ambari-server upgrade". Vitaly, as you may have a test setup for this fix can you test it and open JIRAs if needed.
>
> Vitalyi Brodetskyi wrote:
> Sumit, could you please give me some list of test cases that i should test and create a ticket(if it will be needed)
Any failure case - e.g. mysql server is stopped. In that case, ambari-server upgrade or ambari-server upgrade-stack will fail. Do we see the error on the console?
- Sumit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17393/#review32835
-----------------------------------------------------------
On Jan. 27, 2014, 6:56 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17393/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 6:56 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
>
>
> Bugs: AMBARI-4425
> https://issues.apache.org/jira/browse/AMBARI-4425
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Similar to Oracle/Postgres we need to make sure that ambari-server upgradestack works for MySQL
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py 2ace986
> ambari-server/src/main/resources/upgrade/dml/Ambari-DML-MySQL-UPGRADE_STACK.sql PRE-CREATION
> ambari-server/src/test/python/TestAmbariServer.py 0e90d7b
>
> Diff: https://reviews.apache.org/r/17393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 17393: Add upgradestack support for MySQL
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
> On Jan. 27, 2014, 4:54 p.m., Sumit Mohanty wrote:
> > Can we add a unit test that verifies that upgradestack is called when "ambari-server upgrade" is called?
> >
> > This is not critical for this specific JIRA but if upgradestack encounters an error then will it be logged to console when we call "ambari-server upgrade". Vitaly, as you may have a test setup for this fix can you test it and open JIRAs if needed.
Sumit, could you please give me some list of test cases that i should test and create a ticket(if it will be needed)
- Vitalyi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17393/#review32835
-----------------------------------------------------------
On Jan. 27, 2014, 6:56 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17393/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 6:56 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
>
>
> Bugs: AMBARI-4425
> https://issues.apache.org/jira/browse/AMBARI-4425
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Similar to Oracle/Postgres we need to make sure that ambari-server upgradestack works for MySQL
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py 2ace986
> ambari-server/src/main/resources/upgrade/dml/Ambari-DML-MySQL-UPGRADE_STACK.sql PRE-CREATION
> ambari-server/src/test/python/TestAmbariServer.py 0e90d7b
>
> Diff: https://reviews.apache.org/r/17393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 17393: Add upgradestack support for MySQL
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
> On Jan. 27, 2014, 4:54 p.m., Sumit Mohanty wrote:
> > Can we add a unit test that verifies that upgradestack is called when "ambari-server upgrade" is called?
> >
> > This is not critical for this specific JIRA but if upgradestack encounters an error then will it be logged to console when we call "ambari-server upgrade". Vitaly, as you may have a test setup for this fix can you test it and open JIRAs if needed.
>
> Vitalyi Brodetskyi wrote:
> Sumit, could you please give me some list of test cases that i should test and create a ticket(if it will be needed)
>
> Sumit Mohanty wrote:
> Any failure case - e.g. mysql server is stopped. In that case, ambari-server upgrade or ambari-server upgrade-stack will fail. Do we see the error on the console?
Yes Sumit, in this case user will see the error on the console.
- Vitalyi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17393/#review32835
-----------------------------------------------------------
On Jan. 27, 2014, 6:56 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17393/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 6:56 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
>
>
> Bugs: AMBARI-4425
> https://issues.apache.org/jira/browse/AMBARI-4425
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Similar to Oracle/Postgres we need to make sure that ambari-server upgradestack works for MySQL
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py 2ace986
> ambari-server/src/main/resources/upgrade/dml/Ambari-DML-MySQL-UPGRADE_STACK.sql PRE-CREATION
> ambari-server/src/test/python/TestAmbariServer.py 0e90d7b
>
> Diff: https://reviews.apache.org/r/17393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 17393: Add upgradestack support for MySQL
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17393/#review32835
-----------------------------------------------------------
Can we add a unit test that verifies that upgradestack is called when "ambari-server upgrade" is called?
This is not critical for this specific JIRA but if upgradestack encounters an error then will it be logged to console when we call "ambari-server upgrade". Vitaly, as you may have a test setup for this fix can you test it and open JIRAs if needed.
- Sumit Mohanty
On Jan. 27, 2014, 3:24 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17393/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 3:24 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
>
>
> Bugs: AMBARI-4425
> https://issues.apache.org/jira/browse/AMBARI-4425
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Similar to Oracle/Postgres we need to make sure that ambari-server upgradestack works for MySQL
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py 2ace986
> ambari-server/src/main/resources/upgrade/dml/Ambari-DML-MySQL-UPGRADE_STACK.sql PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>