You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by Robert Newson <ro...@gmail.com> on 2010/07/26 14:09:03 UTC
A spanner in the SSL works.
All,
Jan was reviewing my ssl branch
(http://github.com/rnewson/couchdb/tree/ssl) and was curious as to why
I had disabled MaxConnections. The short answer is, the newer version
of Mochiweb (that supports SSL) no longer supports a configuration
maximum number of connections. It used to (and does in CouchDB 1.0)
but doesn't any more. The code that accepts sockets has been
rewritten, it seems.
B.
Re: A spanner in the SSL works.
Posted by Robert Newson <ro...@gmail.com>.
Not a problem, long commit messages are something of a speciality. I'm
deep in the middle of some unrelated work right now but I'll try to
push this to trunk later tonight.
B.
On Mon, Jul 26, 2010 at 5:43 PM, J Chris Anderson <jc...@apache.org> wrote:
>
> On Jul 26, 2010, at 9:21 AM, Robert Newson wrote:
>
>> I can merge this work to trunk then?
>>
>
> Works for me! If it's gonna cause issues, then getting it in trunk sooner is better than later.
>
> I'm for one, sorta clueless about the whole SSL thing, so perhaps a longish commit message or something saying when / how this is useful would help.
>
> Thanks,
>
> Chris
>
>> B.
>>
>> On Mon, Jul 26, 2010 at 4:58 PM, J Chris Anderson <jc...@gmail.com> wrote:
>>> Mikeal and I talked with Eric Florenzo about this change in Mochiweb at the Github meetup. Apparently it's a *good thing* as the socket accept rewrite cuts down on some rare slow responses Mochiweb sometimes gives.
>>>
>>> So I'm happy to see how this upgrade effects us.
>>>
>>> Chris
>>>
>>> On Jul 26, 2010, at 5:37 AM, Jan Lehnardt wrote:
>>>
>>>> Except for this, the patch looks good to me.
>>>>
>>>> Cheers
>>>> Jan
>>>> --
>>>>
>>>> On 26 Jul 2010, at 14:09, Robert Newson wrote:
>>>>
>>>>> All,
>>>>>
>>>>> Jan was reviewing my ssl branch
>>>>> (http://github.com/rnewson/couchdb/tree/ssl) and was curious as to why
>>>>> I had disabled MaxConnections. The short answer is, the newer version
>>>>> of Mochiweb (that supports SSL) no longer supports a configuration
>>>>> maximum number of connections. It used to (and does in CouchDB 1.0)
>>>>> but doesn't any more. The code that accepts sockets has been
>>>>> rewritten, it seems.
>>>>>
>>>>> B.
>>>>
>>>
>>>
>
>
Re: A spanner in the SSL works.
Posted by J Chris Anderson <jc...@apache.org>.
On Jul 26, 2010, at 9:21 AM, Robert Newson wrote:
> I can merge this work to trunk then?
>
Works for me! If it's gonna cause issues, then getting it in trunk sooner is better than later.
I'm for one, sorta clueless about the whole SSL thing, so perhaps a longish commit message or something saying when / how this is useful would help.
Thanks,
Chris
> B.
>
> On Mon, Jul 26, 2010 at 4:58 PM, J Chris Anderson <jc...@gmail.com> wrote:
>> Mikeal and I talked with Eric Florenzo about this change in Mochiweb at the Github meetup. Apparently it's a *good thing* as the socket accept rewrite cuts down on some rare slow responses Mochiweb sometimes gives.
>>
>> So I'm happy to see how this upgrade effects us.
>>
>> Chris
>>
>> On Jul 26, 2010, at 5:37 AM, Jan Lehnardt wrote:
>>
>>> Except for this, the patch looks good to me.
>>>
>>> Cheers
>>> Jan
>>> --
>>>
>>> On 26 Jul 2010, at 14:09, Robert Newson wrote:
>>>
>>>> All,
>>>>
>>>> Jan was reviewing my ssl branch
>>>> (http://github.com/rnewson/couchdb/tree/ssl) and was curious as to why
>>>> I had disabled MaxConnections. The short answer is, the newer version
>>>> of Mochiweb (that supports SSL) no longer supports a configuration
>>>> maximum number of connections. It used to (and does in CouchDB 1.0)
>>>> but doesn't any more. The code that accepts sockets has been
>>>> rewritten, it seems.
>>>>
>>>> B.
>>>
>>
>>
Re: A spanner in the SSL works.
Posted by Robert Newson <ro...@gmail.com>.
I can merge this work to trunk then?
B.
On Mon, Jul 26, 2010 at 4:58 PM, J Chris Anderson <jc...@gmail.com> wrote:
> Mikeal and I talked with Eric Florenzo about this change in Mochiweb at the Github meetup. Apparently it's a *good thing* as the socket accept rewrite cuts down on some rare slow responses Mochiweb sometimes gives.
>
> So I'm happy to see how this upgrade effects us.
>
> Chris
>
> On Jul 26, 2010, at 5:37 AM, Jan Lehnardt wrote:
>
>> Except for this, the patch looks good to me.
>>
>> Cheers
>> Jan
>> --
>>
>> On 26 Jul 2010, at 14:09, Robert Newson wrote:
>>
>>> All,
>>>
>>> Jan was reviewing my ssl branch
>>> (http://github.com/rnewson/couchdb/tree/ssl) and was curious as to why
>>> I had disabled MaxConnections. The short answer is, the newer version
>>> of Mochiweb (that supports SSL) no longer supports a configuration
>>> maximum number of connections. It used to (and does in CouchDB 1.0)
>>> but doesn't any more. The code that accepts sockets has been
>>> rewritten, it seems.
>>>
>>> B.
>>
>
>
Re: A spanner in the SSL works.
Posted by J Chris Anderson <jc...@gmail.com>.
Mikeal and I talked with Eric Florenzo about this change in Mochiweb at the Github meetup. Apparently it's a *good thing* as the socket accept rewrite cuts down on some rare slow responses Mochiweb sometimes gives.
So I'm happy to see how this upgrade effects us.
Chris
On Jul 26, 2010, at 5:37 AM, Jan Lehnardt wrote:
> Except for this, the patch looks good to me.
>
> Cheers
> Jan
> --
>
> On 26 Jul 2010, at 14:09, Robert Newson wrote:
>
>> All,
>>
>> Jan was reviewing my ssl branch
>> (http://github.com/rnewson/couchdb/tree/ssl) and was curious as to why
>> I had disabled MaxConnections. The short answer is, the newer version
>> of Mochiweb (that supports SSL) no longer supports a configuration
>> maximum number of connections. It used to (and does in CouchDB 1.0)
>> but doesn't any more. The code that accepts sockets has been
>> rewritten, it seems.
>>
>> B.
>
Re: A spanner in the SSL works.
Posted by Jan Lehnardt <ja...@apache.org>.
Except for this, the patch looks good to me.
Cheers
Jan
--
On 26 Jul 2010, at 14:09, Robert Newson wrote:
> All,
>
> Jan was reviewing my ssl branch
> (http://github.com/rnewson/couchdb/tree/ssl) and was curious as to why
> I had disabled MaxConnections. The short answer is, the newer version
> of Mochiweb (that supports SSL) no longer supports a configuration
> maximum number of connections. It used to (and does in CouchDB 1.0)
> but doesn't any more. The code that accepts sockets has been
> rewritten, it seems.
>
> B.