You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/10/21 02:30:18 UTC
[GitHub] [incubator-doris] xinghuayu007 opened a new pull request #4492: [New Feathure] Make Unique key semi join syntax error more clear
xinghuayu007 opened a new pull request #4492:
URL: https://github.com/apache/incubator-doris/pull/4492
## Proposed changes
**"SELECT * FROM t1 LEFT SEMI JOIN t0 ON t1.c0 = t0.c0"**, and **"t0"** is an unique key. This select clause will appear error: "Illegal column/field reference 't0.__DORIS_DELETE_SIGN__' of semi-/anti-join", but user don't know what is the meaning of this error, how to solve this problem. In this patch, it will tell user "__DORIS_DELETE_SIGN__ is a hidden column to mark whether a row deleted when unique key existed, '__DORIS_DELETE_SIGN__ = 0' will appear in where clause, that will cause semi join syntax error, please use '[not] in/existed' as replacement."
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] If this change need a document change, I have updated the document
- [x] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman closed pull request #4492: [New Feathure] Make Unique key semi join syntax error more clear
Posted by GitBox <gi...@apache.org>.
morningman closed pull request #4492:
URL: https://github.com/apache/incubator-doris/pull/4492
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg edited a comment on pull request #4492: [New Feathure] Make Unique key semi join syntax error more clear
Posted by GitBox <gi...@apache.org>.
yangzhg edited a comment on pull request #4492:
URL: https://github.com/apache/incubator-doris/pull/4492#issuecomment-684581069
This is a bug , if a table has delete sign column, it will throw erros when using semi/anti join.
I will fix this bug, so there is no need to modify the error message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #4492: [New Feathure] Make Unique key semi join syntax error more clear
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #4492:
URL: https://github.com/apache/incubator-doris/pull/4492#issuecomment-685318385
Thank you for you PR.
But I will close it because it should be fixed in #4498
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on pull request #4492: [New Feathure] Make Unique key semi join syntax error more clear
Posted by GitBox <gi...@apache.org>.
yangzhg commented on pull request #4492:
URL: https://github.com/apache/incubator-doris/pull/4492#issuecomment-684581069
This is a bug , if a table has delete sign column, it will throw erros when using semi/anti join.
I will fix this bug
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman closed pull request #4492: [New Feathure] Make Unique key semi join syntax error more clear
Posted by GitBox <gi...@apache.org>.
morningman closed pull request #4492:
URL: https://github.com/apache/incubator-doris/pull/4492
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman removed a comment on pull request #4492: [New Feathure] Make Unique key semi join syntax error more clear
Posted by GitBox <gi...@apache.org>.
morningman removed a comment on pull request #4492:
URL: https://github.com/apache/incubator-doris/pull/4492#issuecomment-685318385
Thank you for you PR.
But I will close it because it should be fixed in #4498
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org