You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "dentiny (via GitHub)" <gi...@apache.org> on 2026/03/24 11:09:58 UTC

[PR] feat(s3): validate checksum before making HTTP requests [opendal]

dentiny opened a new pull request, #7296:
URL: https://github.com/apache/opendal/pull/7296

   # Which issue does this PR close?
   
   Closes https://github.com/apache/opendal/issues/7295
   
   # Rationale for this change
   
   Hi team, I was using the following code to create multipart upload request and get a 400 Bad Request from in-house S3.
   ```rust
   let op = Operator::new(S3::default().bucket(xxx).region(yyy).checksum_algorithm("md5"))?;
   op.write(content).chunk(xxx).concurrent(yyy).await?;
   ```
   The reason is multipart upload request doesn't support MD5 as checksum algorithm.
   https://docs.aws.amazon.com/AmazonS3/latest/API/API_CreateMultipartUpload.html#API_CreateMultipartUpload_RequestParameters
   
   # What changes are included in this PR?
   
   In this PR, I validate the checksum before sending out HTTP requests.
   
   # Are there any user-facing changes?
   
   No.
   
   # AI Usage Statement
   
   I made the code change, opus 4.6 did a sanity check for supported checksum algorithms for other type of requests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(s3): validate checksum before making HTTP requests [opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #7296:
URL: https://github.com/apache/opendal/pull/7296


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org