You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "me2seeks (via GitHub)" <gi...@apache.org> on 2026/08/26 15:37:42 UTC
[PR] feat(runtime-host): carry exact Connection identity in Session model targets [maka]
me2seeks opened a new pull request, #3940:
URL: https://github.com/apache/maka/pull/3940
## Summary
Depends on #3864. Until that PR lands, Files changed temporarily includes its immutable Session identity foundation. Review the #3926 increment as range 16841bd50..3b7807a5a.
This PR closes the exact account-selection wire and recovery path:
- explicit Session model targets carry connectionId + connectionSlug + model;
- Session catalog projections expose a required nullable connectionId;
- Runtime Host owns patch merge, exact target validation, and the atomic Session configuration commit;
- CLI/TUI and Desktop preserve the same immutable target across revision-conflict retries;
- legacy or deleted-account Sessions recover only after an explicit account selection;
- non-model updates preserve the original account, including after same-slug reuse;
- TUI and Desktop distinguish legacy, disabled, deleted, and identity-mismatched account state.
Fixes #3926
## Breaking wire change
RUNTIME_HOST_COMPATIBILITY_EPOCH advances from 51 to 52. The projection field, explicit target shape, and configuration patch operation are intentionally closed and incompatible with epoch-51 peers.
Configuration updates no longer accept a default target. An omitted model target means preserve the persisted tuple; only an explicit exact target can change or recover the account and clear NO_REAL_CONNECTION. Session creation still supports the Host-owned canonical default.
## Review focus
- Host authority: packages/runtime-host/src/server/session-catalog-coordinator.ts
- Protocol and epoch: packages/runtime-host/src/protocol/session-catalog.ts and packages/runtime-host/src/protocol/index.ts
- Real delete/reuse/recovery path: packages/runtime-host/src/__tests__/session-catalog-two-client-uds.test.ts
- Exact CAS replay: Desktop runtime-host-client and CLI runtime-host-session-driver tests
- Surface identity and recovery: CLI TUI runner and Desktop model-selection files
## Verification
- Runtime Host full suite: 1262 passed, 0 failed, 9 skipped
- Runtime Host protocol/coordinator/real UDS: 109 passed
- CLI/TUI focused: 232 passed
- Desktop affected suites: 118 passed
- Core exact projection/model tests: 19 passed
- Runtime SessionManager: 208 passed
- Core, Runtime, Runtime Host, Eval, Desktop main and Desktop renderer builds/typechecks: pass
- Biome on all 77 changed files and git diff --check: pass
- Two independent final code reviews on 3b7807a5a: GO, no P0-P2 findings
Known baseline/environment blockers:
- CLI full build cannot resolve @agentclientprotocol/sdk in this isolated worktree; changed CLI output was emitted and the affected 232 tests pass.
- UI build reports the same settledText, conversationKey, unlockAutoFollow, and trailingAction errors on the #3864 base worktree; no new changed-surface error is introduced by this PR.
## Stacked PR lifecycle
- [ ] #3864 merged
- [ ] Rebase this branch onto current main
- [ ] Re-run freshness validation and final dual review
- [ ] Mark ready for review
## AI use
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: Codex implemented the Runtime Host wire, surface adoption, tests, validation, and review integration. The commit includes a Generated-by trailer.
## Checklist
- [x] Tests cover the change and fail without it
- [ ] Lint, format, typecheck and the affected suites pass locally
The affected suites, formatting, and scoped typechecks pass. The unchecked item records the two baseline/environment blockers described above.
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] feat(runtime-host): carry exact Connection identity in Session model targets [maka]
Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks closed pull request #3940: feat(runtime-host): carry exact Connection identity in Session model targets
URL: https://github.com/apache/maka/pull/3940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] feat(runtime-host): carry exact Connection identity in Session model targets [maka]
Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks commented on PR #3940:
URL: https://github.com/apache/maka/pull/3940#issuecomment-5433745372
Superseded by #3864 at `bad6984f8`. The exact Session Connection identity wire, Runtime Host authority, and Desktop/CLI/TUI recovery were recombined there to avoid an unsafe intermediate state for legacy Sessions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org