You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/01/03 21:18:14 UTC

[GitHub] [logging-log4j2] vy commented on pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

vy commented on pull request #452:
URL: https://github.com/apache/logging-log4j2/pull/452#issuecomment-753677605


   @carterkozak, after giving it some thought, I have decided to go with your proposal. In a nutshell, what the most recent change set incorporates is as follows:
   
   - `AppenderControl` catch clauses is demoted from `Throwable` to `Exception`.
   - `AsyncAppender.AsyncThread` is moved to `AsyncAppenderEventForwarder` with plenty of refactoring for simplification.
   - On shutdown, `AsyncAppenderEventForwarder` forwards all the remaining `LogEvent`s, whereas `AsyncAppender.AsyncThread` was ignoring non-`Log4LogEvent`s.
   - `AsyncAppenderExceptionHandlingTest` is improved for `ThreadDeath`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org