You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "hedger9487 (via GitHub)" <gi...@apache.org> on 2026/08/24 21:09:48 UTC
[PR] Avro: Cache Avro schema conversion in AvroFileHeader.get_schema (#3662) [iceberg-python]
hedger9487 opened a new pull request, #3844:
URL: https://github.com/apache/iceberg-python/pull/3844
### Description
Fixes #3662.
Every manifest file under a partition spec embeds an identical Avro schema string (`avro.schema`). Previously, `AvroFileHeader.get_schema()` in `pyiceberg/avro/file.py` performed a full `json.loads()` and recursive `AvroSchemaConversion().avro_to_iceberg()` conversion on every manifest read during scan planning.
This PR adds an LRU cache for Avro schema string parsing via `_parse_avro_schema`, avoiding redundant conversions across repeated manifest reads during scan planning (e.g. accelerating `scan().plan_files()` by ~1.8x on tables with many manifests).
### Testing
- Added unit test `test_get_schema_is_cached` in `tests/avro/test_file.py`.
- All 49 Avro and manifest tests pass locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Avro: Cache Avro schema conversion in AvroFileHeader.get_schema (#3662) [iceberg-python]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3844:
URL: https://github.com/apache/iceberg-python/pull/3844#issuecomment-5805250089
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Avro: Cache Avro schema conversion in AvroFileHeader.get_schema (#3662) [iceberg-python]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3844:
URL: https://github.com/apache/iceberg-python/pull/3844#issuecomment-5922342986
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Avro: Cache Avro schema conversion in AvroFileHeader.get_schema (#3662) [iceberg-python]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3844: Avro: Cache Avro schema conversion in AvroFileHeader.get_schema (#3662)
URL: https://github.com/apache/iceberg-python/pull/3844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org