You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/02/16 14:25:08 UTC
[GitHub] [arrow-datafusion] jackwener opened a new pull request, #5304: fix: correct plan builder when test `scalar_subquery_project_expr`
jackwener opened a new pull request, #5304:
URL: https://github.com/apache/arrow-datafusion/pull/5304
# Which issue does this PR close?
Closes #.
# Rationale for this change
This test build a wrong plan (problem in projection)l
# What changes are included in this PR?
build right plan and enable this test.
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5304: fix: correct plan builder when test `scalar_subquery_project_expr`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5304:
URL: https://github.com/apache/arrow-datafusion/pull/5304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5304: fix: correct plan builder when test `scalar_subquery_project_expr`
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5304:
URL: https://github.com/apache/arrow-datafusion/pull/5304#issuecomment-1433597388
Benchmark runs are scheduled for baseline = dd8a2a79ebfca5a4fd14c9ed3198ba8da9c20d44 and contender = fed4019d556f4afb3156fd12c21608e08b8d7eb6. fed4019d556f4afb3156fd12c21608e08b8d7eb6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/20b8eaa5d1d94544a5bd306f2aafb076...b8c35006f8e34575952b4958c4c1aa31/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d613c8a6ec8347ae90104a250db77e8b...638a943104f8421aa0cfd4425f971468/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/785dd1fb70814d069c9a701ad1dc46e1...d0b2e5e4e71c4750a7c9cfc9b9204d21/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/afcb0bc322a146a1a45c4c49ae535d65...283203c9aac2484dbd4dab8015bce53d/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org